Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: deprecated dependencies #530

Open
herrKlein opened this issue Dec 20, 2024 · 1 comment
Open

[Bug]: deprecated dependencies #530

herrKlein opened this issue Dec 20, 2024 · 1 comment
Labels
bug Something isn't working dependencies Update one or more dependencies version

Comments

@herrKlein
Copy link

Describe the bug

npm install yields deprecated dependencies on test-runner.
On a clean storybook install this package is the only one using deprecated packages.

npm warn deprecated [email protected]: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
npm warn deprecated [email protected]: Rimraf versions prior to v4 are no longer supported
npm warn deprecated [email protected]: Glob versions prior to v9 are no longer supported
npm warn deprecated [email protected]: Glob versions prior to v9 are no longer supported
npm warn deprecated [email protected]: Glob versions prior to v9 are no longer supported
npm warn deprecated [email protected]: Glob versions prior to v9 are no longer supported
npm warn deprecated [email protected]: Glob versions prior to v9 are no longer supported
npm warn deprecated [email protected]: Glob versions prior to v9 are no longer supported

To Reproduce

npm install
on
"@storybook/test-runner": "^0.21.0",

System

Storybook Environment Info:

  System:
    OS: macOS 15.2
    CPU: (12) arm64 Apple M3 Pro
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.15.1 - ~/.nvm/versions/node/v20.15.1/bin/node
    npm: 10.9.0 - ~/.nvm/versions/node/v20.15.1/bin/npm <----- active
  Browsers:
    Chrome: 131.0.6778.205
    Safari: 18.2
  npmPackages:
    @storybook/addon-a11y: ^8.4.7 => 8.4.7 
    @storybook/addon-essentials: ^8.4.7 => 8.4.7 
    @storybook/addon-interactions: ^8.4.7 => 8.4.7 
    @storybook/addon-links: ^8.4.7 => 8.4.7 
    @storybook/addon-storysource: ^8.4.7 => 8.4.7 
    @storybook/blocks: ^8.4.7 => 8.4.7 
    @storybook/preview-api: ^8.4.7 => 8.4.7 
    @storybook/test: ^8.4.7 => 8.4.7 
    @storybook/test-runner: ^0.21.0 => 0.21.0 
    @storybook/web-components: ^8.4.7 => 8.4.7 
    @storybook/web-components-vite: ^8.4.7 => 8.4.7 
    chromatic: ^11.20.0 => 11.20.0 
    eslint-plugin-storybook: ^0.11.1 => 0.11.1 
    storybook: ^8.4.7 => 8.4.7 
    storybook-addon-tag-badges: ^1.3.2 => 1.3.2 
    wc-storybook-helpers: ^2.0.4 => 2.0.4

Additional context

No response

@herrKlein herrKlein added bug Something isn't working needs triage labels Dec 20, 2024
@yannbf
Copy link
Member

yannbf commented Dec 24, 2024

Hey @herrKlein thanks for the report!

Here's a breakdown of the deprecations:

glob

└─┬ @storybook/[email protected]
  ├─┬ [email protected]
  │ └─┬ [email protected]
  │   └── [email protected] deduped
  ├─┬ [email protected]
  │ └─┬ [email protected]
  │   └── [email protected] deduped
  ├─┬ [email protected]
  │ └─┬ @jest/[email protected]
  │   ├─┬ @jest/[email protected]
  │   │ └── [email protected] deduped
  │   └─┬ [email protected]
  │     └── [email protected] deduped
  └─┬ [email protected]
    ├── [email protected]
    └─┬ [email protected]
      └── [email protected] deduped

rimraf

└─┬ @storybook/[email protected]
  ├─┬ [email protected]
  │ └── [email protected]
  └─┬ [email protected]
    ├─┬ [email protected]
    │ └── [email protected] deduped
    ├── [email protected] deduped
    └─┬ [email protected]
      └── [email protected] deduped

inflight

└─┬ @storybook/[email protected]
  └─┬ [email protected]
    └─┬ [email protected]
      └── [email protected]

Unfortunately we don't have control over NYC or jest-playwright-preset. Even if the test-runner would upgrade to NYC v17, its still uses glob v7. So perhaps what you can do for now is use package overrides to upgrade these dependencies?

@yannbf yannbf added dependencies Update one or more dependencies version and removed needs triage labels Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Update one or more dependencies version
Projects
None yet
Development

No branches or pull requests

2 participants