Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails back to closed state on failure to check state after calling open API? #257

Open
sjefferson99 opened this issue Oct 30, 2024 · 0 comments
Assignees
Labels
🐛 bug Something isn't working 👁 smib-hid SMIBHID related code
Milestone

Comments

@sjefferson99
Copy link
Member

Observed behaviour tonight where I adjusted space state from closed to open for 4 hours, but it took a while to try and apply space state and said API was slow. It then finally said space state was closed and did so for a few more seconds, it then updated to space open.

It would have been likely that someone would have then tried again and therefore submitted space open twice.

Need to check if it's possible that a space state change to open could drop back to closed if the right API failure/space state failure directly after occurred.

Correct behaviour should be not changing state unless a definite response received from server and to otherwise stay in updating/error state, also ensure no paused checks get applied after state change i.e. space closed received, but paused as updating state, then applied when API call timed out.

@sjefferson99 sjefferson99 added 🐛 bug Something isn't working 👁 smib-hid SMIBHID related code labels Oct 30, 2024
@sjefferson99 sjefferson99 added this to the SMIB v1.3 milestone Oct 30, 2024
@sjefferson99 sjefferson99 self-assigned this Oct 30, 2024
@sjefferson99 sjefferson99 modified the milestones: SMIB v1.3, SMIB v1.4 Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working 👁 smib-hid SMIBHID related code
Projects
None yet
Development

No branches or pull requests

1 participant