Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to add to hours counter once already open #254

Closed
sam57719 opened this issue Oct 23, 2024 · 2 comments · Fixed by #255
Closed

Ability to add to hours counter once already open #254

sam57719 opened this issue Oct 23, 2024 · 2 comments · Fixed by #255
Assignees
@sjefferson99
Labels
Discussion 💡 idea Possible ideas for the future 👁 smib-hid SMIBHID related code
Milestone
SMIB v1.3

Comments

@sam57719
Copy link
Collaborator

SMIBHID feature suggestion: pressing the open button when the space is open should add time to the timer, or if no timer is currently set, set the timer

Slack Message
@sam57719 sam57719 added Discussion 👁 smib-hid SMIBHID related code 💡 idea Possible ideas for the future labels Oct 23, 2024
@sjefferson99 sjefferson99 self-assigned this Oct 28, 2024
@sjefferson99 sjefferson99 added this to the SMIB v1.3 milestone Oct 28, 2024
sjefferson99 added a commit that referenced this issue Oct 28, 2024
@sjefferson99
Ability to "top up" space open hours if already open. Closes #254
04ff18d
@sjefferson99 sjefferson99 linked a pull request Oct 28, 2024 that will close this issue
Ability to "top up" space open hours if already open. Closes #254 #255
Merged
@sjefferson99
Copy link
Member

@sam57719 There is no timer as such, it's just a post with hours open. You could have a timer implemented on the smib side and you can interpret the new hours open as top up or reset to new value as you like. That should be a new issue, this one deals with the SMIBHID element.

@sam57719 sam57719 mentioned this issue Oct 29, 2024
Open
@sam57719
Copy link
Collaborator Author

raised #256 to cover SMIB element

sjefferson99 added a commit that referenced this issue Oct 30, 2024
@sjefferson99
Merge pull request #255 from somakeit/254-ability-to-add-to-hours-cou…
e504d1e 
…nter-once-already-open

Ability to "top up" space open hours if already open. Closes #254
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sjefferson99 sjefferson99

Labels
Discussion 💡 idea Possible ideas for the future 👁 smib-hid SMIBHID related code
Projects
None yet
Milestone
SMIB v1.3
Development

Successfully merging a pull request may close this issue.

Ability to "top up" space open hours if already open. Closes #254 somakeit/smib
2 participants
@sjefferson99 @sam57719