Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for musl wheels #400

Closed
wants to merge 1 commit into from
Closed

Conversation

ObserverOfTime
Copy link

@ObserverOfTime ObserverOfTime commented Aug 14, 2022

This closes #391. I've tested the musl wheel on Alpine edge and it works.

It might be worth creating a new release if and when this PR is merged.
Both this change and the Python 2 removal (d333e3c) are quite important.

@asottile
Copy link
Member

please don't touch unrelated files

@ObserverOfTime
Copy link
Author

OK, I'll let you fix those yourself.

@asottile
Copy link
Member

is this image official? I can't find any docs for it

@ObserverOfTime
Copy link
Author

It's official. It was added in pypa/manylinux#1135.

@asottile
Copy link
Member

it's undocumented so I would prefer to wait until the linked issue there is resolved before depending on undocumented behavior

@ObserverOfTime
Copy link
Author

So, it's fine to depend on a deprecated image (manylinux1) but not an undocumented one?

@ObserverOfTime
Copy link
Author

The "undocumented" image is already used by pypa/cibuildwheel. There's really no reason not to depend on it.

@ObserverOfTime
Copy link
Author

Would you accept a pull request that builds the wheels with cibuildwheel on GitHub actions instead?

@ObserverOfTime
Copy link
Author

I'll take that as a no.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add wheels for musl linux
2 participants