feat: python2 to 3 #569
Closed
feat: python2 to 3 #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacobCoffee
added
the
infrastructure
JacobCoffee
commented
Jul 22, 2024
| @@ -230,6 +235,7 @@ def handle_data(self, text): | |||
| text = text.replace('<', '') | |||
| _BaseHTMLProcessor.handle_data(self, text) | |||
|
|
|||
| # TODO(py2to3): we need to replace `mx` and `tidy` here | |||
There was a problem hiding this comment.
would appreciate some insight here, im out of my zone
JacobCoffee
commented
Jul 22, 2024
| @@ -1726,6 +1741,7 @@ def handle_data(self, text): | |||
| if not self.unacceptablestack: | |||
| _BaseHTMLProcessor.handle_data(self, text) | |||
|
|
|||
| # TODO(py2to3): replace tidy and mx | |||
offbyone
reviewed
Oct 5, 2024
| "(%d) %s" % (filename, errno, errstr) | ||
| except IOError as e: | ||
| raise TemplateError("IO error while reading template '%s': " \ | ||
| "(%d) %s" % (filename, e.errno, e.errstr)) |
There was a problem hiding this comment.
Automated conversion has failed ya a bit here. If you have a misconfiguration, with a missing template file, you'll hit this and get:
File "/Users/offby1/projects/planet-python/code/planet/htmltmpl.py", line 981, in compile
tokens = self.parse(self.read(file))
File "/Users/offby1/projects/planet-python/code/planet/htmltmpl.py", line 1032, in read
"(%d) %s" % (filename, e.errno, e.errstr))
AttributeError: 'FileNotFoundError' object has no attribute 'errstr'
|
Closing in favor of #577 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Probably the best changeset is at bc58d1c and before.
How
Ran
2to3->[email protected]->removed 2to3.bakfiles-> manually went through (large amount of) remaining issuesIssues
planetto Ubuntu 24.04 - Requires updating toPython3#568Todo
(These have high usages of sgbmlib and other HTML stuff, pretty lost.)
sanitize.pyfeedparser.pyFile "/planet/code/planet/feedparser.py", line 2947:_LOCALTZONES` no longer exists (?)