-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG]: Cannot redefine key #107
Comments
Fix SummaryI resolved an issue related to package installation in the CI/CD pipeline. Here's how:
|
We should probably create some sort of merge mechanic like in #39 |
Hi @carlosmfreitas2409 and @Yurchishin, could you please test my PR fixing this issue? I think |
Hi @Yurchishin and @xhyrom First of all, thanks for the answers guys! To update you guys. I didn't have any Since the Bun action creates the So the first time, when Even though I was committing the file that is being created from the action, I think this should not happen, right? (I could be wrong) Because theoretically, if I create the file manually, it will have the same content/code that the action created and the same error would happen again (I haven't tested this). So the temporary solution I had was to delete the I will test if your PR resolves it in a few hours @xhyrom, thank you so much! |
Thanks, I wonder that we should probably also handle this case by removing the bunfig at the end / reverthing the content of the file 🤔 |
Yes, I believe it would be important. However, it would not solve all cases (including this one). Let's suppose that I wanted to publish a lib on the Github Registry and for that I need to use the
In the above step, it will work. However, if between these steps we are using something that commits, bunfig will still be committed because the post-setup will not have been run yet. Example:
Lines 46 to 48 in 8f1bc2e
Maybe, instead of writing the bunfig file with (I think this also refers to #99) |
Ohh, yes, you're right about this one, I'll see what we can do. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hi @xhyrom First of all, I apologize for the delay in testing your PR. I tested it here and apparently it solves the problem of this issue, which is having - name: Setup bun
uses: oven-sh/setup-bun@feat/multiple-registries
with:
bun-version: 1.1.34
registries: |
[
{
"registry-url": "https://npm.pkg.github.com/",
"scope": "@repo",
"token": "$BUN_AUTH_TOKEN"
}
]
- name: Install dependencies
env:
BUN_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
run: bun install --frozen-lockfile However, the error in the previous comment, which is to create But I believe this must be another issue, right? -- Another thing that I saw is the possibility of a new parameter in the action, allowing to switch between But I'm sure this should be another issue, so I created the #112 |
Hey, thanks for testing the changes and creating new issue. Before closing this issue as completed, I'll work on the changes to create Also, adding support for |
Hello!
I have the following step (exactly as it says in the README):
And when running the workflow, the following error occurs:
The
bunfig.toml
was created automatically by the action and looks like this:There is an issue with this problem (#33), but it is closed and without a solution.
The text was updated successfully, but these errors were encountered: