-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metrics reader supports configuring aggregation and temporality #1723
Comments
👋 This issue has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the |
I can look into this. |
Thanks, @zvkemp! I've assigned this issue to you. I know @xuan-cao-swi, has been working on something similar, with issue #1742 implemented in PR #1769. It might be that the functionality is there, but we need to confirm it is aligned with the specification. The section in the specs that describes this environment variable is here (with a few references to another config outside the scope of this issue). Let us know if there's anything we can do to help! |
Ok, it seems like #1769 has been marked as targeting this issue specifically. I'll hold off for now, assuming that one will eventually be merged. |
Hi @zvkemp , please do share your thought and code in same or different PR. I opened it as draft as I don't have 100% confidence about the approach I have taken ;) |
The metrics Reader implementation should support configuring the default aggregation and the default temporality on the basis of instrument kind. There are two lines on the spec compliance matrix about this.
This may be the relevant spec: https://opentelemetry.io/docs/specs/otel/metrics/sdk/#metricreader
Our aggregation classes set the temporality and it can be configured using an environment variable,
OTEL_EXPORTER_OTLP_METRICS_TEMPORALITY_PREFERENCE
Our instruments have a default temporality and don't have a public-facing API to change their aggregation. We should look at the configuration options for aggregation and temporality and see if they are compliant. If they are not, update the SDK to make it compliant.
The text was updated successfully, but these errors were encountered: