Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics reader supports configuring aggregation and temporality #1723

Open
kaylareopelle opened this issue Sep 6, 2024 · 5 comments · May be fixed by #1779
Open

Metrics reader supports configuring aggregation and temporality #1723

kaylareopelle opened this issue Sep 6, 2024 · 5 comments · May be fixed by #1779
Assignees

Comments

@kaylareopelle
Copy link
Contributor

The metrics Reader implementation should support configuring the default aggregation and the default temporality on the basis of instrument kind. There are two lines on the spec compliance matrix about this.

This may be the relevant spec: https://opentelemetry.io/docs/specs/otel/metrics/sdk/#metricreader

Our aggregation classes set the temporality and it can be configured using an environment variable, OTEL_EXPORTER_OTLP_METRICS_TEMPORALITY_PREFERENCE

Our instruments have a default temporality and don't have a public-facing API to change their aggregation. We should look at the configuration options for aggregation and temporality and see if they are compliant. If they are not, update the SDK to make it compliant.

Copy link
Contributor

github-actions bot commented Oct 7, 2024

👋 This issue has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the keep label to hold stale off permanently, or do nothing. If you do nothing this issue will be closed eventually by the stale bot.

@github-actions github-actions bot added the stale label Oct 7, 2024
@kaylareopelle kaylareopelle added keep and removed stale labels Oct 7, 2024
@zvkemp
Copy link

zvkemp commented Dec 11, 2024

I can look into this.

@kaylareopelle
Copy link
Contributor Author

kaylareopelle commented Dec 12, 2024

Thanks, @zvkemp! I've assigned this issue to you. I know @xuan-cao-swi, has been working on something similar, with issue #1742 implemented in PR #1769.

It might be that the functionality is there, but we need to confirm it is aligned with the specification. The section in the specs that describes this environment variable is here (with a few references to another config outside the scope of this issue).

Let us know if there's anything we can do to help!

@zvkemp
Copy link

zvkemp commented Dec 13, 2024

Ok, it seems like #1769 has been marked as targeting this issue specifically. I'll hold off for now, assuming that one will eventually be merged.

@xuan-cao-swi
Copy link
Contributor

Hi @zvkemp , please do share your thought and code in same or different PR. I opened it as draft as I don't have 100% confidence about the approach I have taken ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: To do
Development

Successfully merging a pull request may close this issue.

3 participants