The more translations (routes) the lower performance #690

hoiheart · 2020-04-29T22:09:33Z

Version

nuxt-i18n: ^6.10.1 (latest)
nuxt: ^2.0.0 (latest)

Reproduction Link

https://github.com/hoiheart/nuxt-issue-demo/tree/i18n-performance

Steps to reproduce

When the TPS is measured under the same conditions,

with i18n
increase page count
increase message objects

What is Expected?

The request throughput must be similar before and after the module is used. (639 TPS)

What is actually happening?

When the TPS is measured under the same conditions,

Less TPS with i18n (583 TPS)
Less TPS depending on page count (568 TPS)
More message objects significantly reduce TPS (258 TPS)

Since it's a test on a personal PC, the TPS figure doesn't mean much.
But the decline is significant.
If you have any problems with my setup, please give me some advice

rchl · 2020-04-30T06:04:29Z

How are you measuring TPS?
Are you hitting one and the same URL when testing?

hoiheart · 2020-04-30T07:39:00Z

How are you measuring TPS?
Are you hitting one and the same URL when testing?

I used apache jmeter and thread kept calling root and measuring throughput.

hoiheart · 2020-05-11T22:03:18Z

@rchl
Is there any progress on this issue?

rchl · 2020-05-12T06:27:28Z

I haven't had time to try it out yet but planning to do that at some point.

rchl · 2020-05-22T20:55:14Z

It looks like it's mostly the extra routes that nuxt-i18n generates that contribute to the performance issue.

So it really looks like a pure Nuxt (or VueRouter) issue. I don't know if I'll have time to look into it more soon. Maybe someone from core team will (@pi0, @atinux, @manniL). This issue could be even moved to Nuxt repo.

nuxt-i18n with default settings from the repo (focus on /s Avg):

summary +  11573 in 00:00:30 =  385.6/s Avg:    12 Min:     5 Max:    35 Err:     0 (0.00%) Active: 5 Started: 5 Finished: 0
summary =  13503 in 00:00:42 =  323.5/s Avg:    12 Min:     3 Max:   124 Err:     0 (0.00%)
summary +   9267 in 00:00:23 =  397.4/s Avg:    12 Min:     5 Max:    34 Err:     0 (0.00%) Active: 0 Started: 5 Finished: 5
summary =  22770 in 00:01:05 =  350.0/s Avg:    12 Min:     3 Max:   124 Err:     0 (0.00%)

strategy no_prefix (no extra routes):

summary +  25723 in 00:00:30 =  857.4/s Avg:     5 Min:     2 Max:    23 Err:     0 (0.00%) Active: 5 Started: 5 Finished: 0
summary =  30046 in 00:00:42 =  707.2/s Avg:     5 Min:     2 Max:   106 Err:     0 (0.00%)
summary +  19877 in 00:00:23 =  881.4/s Avg:     5 Min:     2 Max:    25 Err:     0 (0.00%) Active: 0 Started: 5 Finished: 5
summary =  49923 in 00:01:05 =  767.6/s Avg:     5 Min:     2 Max:   106 Err:     0 (0.00%)

nuxt_i18n disabled:

summary +  24266 in 00:00:28 =  872.3/s Avg:     5 Min:     2 Max:    20 Err:     0 (0.00%) Active: 5 Started: 5 Finished: 0
summary =  24267 in 00:00:33 =  735.1/s Avg:     5 Min:     2 Max:    76 Err:     0 (0.00%)
summary +  28895 in 00:00:30 =  963.2/s Avg:     5 Min:     2 Max:    21 Err:     0 (0.00%) Active: 5 Started: 5 Finished: 0
summary =  53162 in 00:01:03 =  843.7/s Avg:     5 Min:     2 Max:    76 Err:     0 (0.00%)
summary +   1954 in 00:00:02 =  960.7/s Avg:     5 Min:     2 Max:    17 Err:     0 (0.00%) Active: 0 Started: 5 Finished: 5
summary =  55116 in 00:01:05 =  847.4/s Avg:     5 Min:     2 Max:    76 Err:     0 (0.00%)

nuxt_i18n disabled + only a single index.vue route:

summary +  30191 in 00:00:30 = 1006.4/s Avg:     4 Min:     2 Max:    19 Err:     0 (0.00%) Active: 5 Started: 5 Finished: 0
summary =  33113 in 00:00:40 =  824.1/s Avg:     4 Min:     2 Max:    86 Err:     0 (0.00%)
summary +  27174 in 00:00:25 = 1092.9/s Avg:     4 Min:     1 Max:    16 Err:     0 (0.00%) Active: 0 Started: 5 Finished: 5
summary =  60287 in 00:01:05 =  926.9/s Avg:     4 Min:     1 Max:    86 Err:     0 (0.00%)

(Note: that for testing I've disabled message loading (lazy: false) to focus on bigger fish)
(Note 2: nuxt-i18n also contributes to the issue of course as it has to run some code but the biggest offender seems to be just the number of routes.)

hoiheart · 2020-05-23T12:17:37Z

@rchl
Thank you. I hope this issue is resolved soon. 🙏

rchl · 2020-05-27T21:39:13Z

It's most likely this code creating various maps and lists of routes and especially heavy use of regexpes in it:

https://github.com/vuejs/vue-router/blob/7d7e048490e46f4d433ec6cf897468409d158c9b/src/create-route-map.js#L7-L12

Such things might be hard to optimize as those are things that can't just be skipped. But I don't know that code so maybe there is something that can be done.

FYI @posva

rchl · 2020-05-28T06:20:20Z

See how VueRouter takes big chunk of normal page loading time when there are many routes:

@nxut/content-theme-docs nuxt-modules#690

Croodo · 2021-05-15T20:24:42Z

Will Removing translation messages (locales files) from the lang directory and fetching them through Axios gonna make any difference?
Anyone have a thought about it?

rchl · 2021-05-16T20:25:53Z

The issue identified here is related to the number of routes and not locale files or messages. Fetching them with axios is only gonna make things slower.

Croodo · 2021-05-21T20:50:06Z

@rchl, please invite someone from the core team to investigate the issue. I guess this issue needs to be solved asap.

Croodo · 2021-08-28T20:24:01Z

Any update regarding this issue?

Upgraded from nuxt-i18n to nuxtjs/i18n but still no improvement.

divine · 2021-08-28T21:14:39Z

Any update regarding this issue?

Upgraded from nuxt-i18n to nuxtjs/i18n but still no improvement.

Hello,

Quite interesting that you are blaming this module, it has been already explained that this is upstream issue that can't be fixed here.

Also, if this is needs to be solved ASAP, you could just push a PR with the fix. Would be really helpful, right?

Thanks!

Croodo · 2021-08-29T20:33:23Z

Any update regarding this issue?
Upgraded from nuxt-i18n to nuxtjs/i18n but still no improvement.

Hello,

Quite interesting that you are blaming this module, it has been already explained that this is upstream issue that can't be fixed here.

Also, if this is needs to be solved ASAP, you could just push a PR with the fix. Would be really helpful, right?

Thanks!

First of all, no way I'm blaming the module.
I did the recent comment is just to get the issue noticed by people so that by discussing we can investigate the issue more deeply to find a solution.
I'm extremely sorry, but you get me wrong, I was not blaming.

rchl · 2021-08-30T06:18:30Z

It's an upstream issue so it would more relevant to track nuxt/nuxt#7473 for example.
Maybe there should also be an issue in VueRouter for this, assuming that it concerns itself with SSR also.

coremyslo · 2023-04-14T10:57:25Z

About a year ago, I encountered the same issue.

My solution involved forking and rewriting the module so that it doesn't create a separate route for each locale. Instead, it allows setting up vars in the route for a single locale. Here's an example of the route configuration:

{
    name: `my-route-name`,
    path: `/{foo}-fixed-path-part-{bar}`,
    ...,
    meta: {
        i18n: {
            foo: {
                da: "aaa",
                de: "bbb",
                en: "ccc",
            },
            bar: {
                da: "111",
                de: "222",
                en: "333",
            },
        },
    },
},

for da route path will be parsed as aaa-fixed-path-part-111
for en route path will be parsed as ccc-fixed-path-part-333
etc.

In case of missing value in meta[param][locale] fallback to meta[param][defaultLocale]

I believe this module could be updated to support this route setup method through parameters or by manually parsing the routes as another option.

BobbieGoede · 2024-02-13T22:23:23Z

Performance still gets noticeably worse due to the amount of routes generated in v8 (Nuxt 3), we're tracking this in nuxt/nuxt#25612 and vuejs/router#2132.

BobbieGoede · 2024-09-21T20:27:44Z

Closing this as v7 is not being actively worked on (critical hotfixes only), if this still applies to v8 and later please open a new issue!

hoiheart added the bug 🐛 label Apr 29, 2020

hoiheart changed the title ~~The more translations, the lower the performance.~~ The more translations, the lower performance. May 6, 2020

rchl mentioned this issue May 26, 2020

Long loading time, when use 90 or more languages #262

Closed

TheAlexLichter mentioned this issue Jun 6, 2020

Instantiating Vue Router everytime causes serious performance problem nuxt/nuxt#7473

Closed

This comment has been minimized.

Sign in to view

stale bot added the stale label Jul 27, 2020

rchl added help wanted pinned 📌 and removed stale labels Jul 27, 2020

rchl mentioned this issue Aug 1, 2020

[I18n] Google page speed - reduce execution time? #815

Closed

farnabaz pushed a commit to farnabaz/i18n-module that referenced this issue Mar 25, 2021

fix(theme-docs): correct releases link

b4e0c69

@nxut/content-theme-docs nuxt-modules#690

rchl added performance and removed bug 🐛 help wanted labels May 9, 2021

rchl mentioned this issue May 9, 2021

The module increasing TBT. Need help #1165

Closed

rchl added the upstream issue label Aug 30, 2021

rchl mentioned this issue Dec 15, 2021

Our website has 13 languages and many pages. I18in generates a lot of routes, which greatly affects the js running speed of the website #1363

Closed

rchl changed the title ~~The more translations, the lower performance.~~ The more translations (routes) the lower performance Dec 15, 2021

This comment has been minimized.

Sign in to view

BobbieGoede added the v7 label Apr 5, 2024

BobbieGoede closed this as not planned Won't fix, can't repro, duplicate, stale Sep 21, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

The more translations (routes) the lower performance #690

The more translations (routes) the lower performance #690

hoiheart commented Apr 29, 2020 •

edited

Loading

rchl commented Apr 30, 2020

hoiheart commented Apr 30, 2020

hoiheart commented May 11, 2020

rchl commented May 12, 2020

rchl commented May 22, 2020 •

edited

Loading

hoiheart commented May 23, 2020

rchl commented May 27, 2020 •

edited

Loading

rchl commented May 28, 2020

This comment has been minimized.

Croodo commented May 15, 2021

rchl commented May 16, 2021 •

edited

Loading

Croodo commented May 21, 2021

Croodo commented Aug 28, 2021

divine commented Aug 28, 2021

Croodo commented Aug 29, 2021

rchl commented Aug 30, 2021

This comment has been minimized.

coremyslo commented Apr 14, 2023 •

edited

Loading

BobbieGoede commented Feb 13, 2024

BobbieGoede commented Sep 21, 2024

The more translations (routes) the lower performance #690

The more translations (routes) the lower performance #690

Comments

hoiheart commented Apr 29, 2020 • edited Loading

Version

Reproduction Link

Steps to reproduce

What is Expected?

What is actually happening?

rchl commented Apr 30, 2020

hoiheart commented Apr 30, 2020

hoiheart commented May 11, 2020

rchl commented May 12, 2020

rchl commented May 22, 2020 • edited Loading

hoiheart commented May 23, 2020

rchl commented May 27, 2020 • edited Loading

rchl commented May 28, 2020

This comment has been minimized.

Croodo commented May 15, 2021

rchl commented May 16, 2021 • edited Loading

Croodo commented May 21, 2021

Croodo commented Aug 28, 2021

divine commented Aug 28, 2021

Croodo commented Aug 29, 2021

rchl commented Aug 30, 2021

This comment has been minimized.

coremyslo commented Apr 14, 2023 • edited Loading

BobbieGoede commented Feb 13, 2024

BobbieGoede commented Sep 21, 2024

hoiheart commented Apr 29, 2020 •

edited

Loading

rchl commented May 22, 2020 •

edited

Loading

rchl commented May 27, 2020 •

edited

Loading

rchl commented May 16, 2021 •

edited

Loading

coremyslo commented Apr 14, 2023 •

edited

Loading