Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turbine Camp #828

Open
6 of 25 tasks
pdhirajkumarprasad opened this issue Sep 12, 2024 · 4 comments
Open
6 of 25 tasks

Turbine Camp #828

pdhirajkumarprasad opened this issue Sep 12, 2024 · 4 comments
Assignees

Comments

@pdhirajkumarprasad
Copy link

pdhirajkumarprasad commented Sep 12, 2024

Contact:

Onnx Ops( Known missing features)

Unassigned

In Progress

Completed

Onnx Ops( Known Quality Issues)

Other tasks:

llvm/torch-mlir#3796

@knwng
Copy link

knwng commented Oct 3, 2024

Seems LSTM also has quality issue. But it seems the testcases themselves are buggy(wrong # of inputs & outputs). Besides, RNN only has 1 testcase rn. I'm afraid it can't cover all the corner cases.

@vivekkhandelwal1
Copy link
Contributor

Seems LSTM also has quality issue. But it seems the testcases themselves are buggy(wrong # of inputs & outputs). Besides, RNN only has 1 testcase rn. I'm afraid it can't cover all the corner cases.

Yeah, the issue for LSTM is already opened here #315.

@vivekkhandelwal1 vivekkhandelwal1 unpinned this issue Oct 8, 2024
@marbre marbre pinned this issue Oct 9, 2024
@vivekkhandelwal1 vivekkhandelwal1 unpinned this issue Nov 12, 2024
@habcode
Copy link

habcode commented Nov 30, 2024

Hello @zjgarvey @pdhirajkumarprasad , I would like to contribute to this repository and thinking of taking ownership of Cast or
DequantizeLinear OP. Would you please share some step by step guide on how to get started?

@zjgarvey
Copy link
Collaborator

Hello @zjgarvey @pdhirajkumarprasad , I would like to contribute to this repository and thinking of taking ownership of Cast or
DequantizeLinear OP. Would you please share some step by step guide on how to get started?

Hi!

  1. clone a fork of llvm/torch-mlir and build it following the directions in docs/development.md in that repository.
  2. Find which tests are failing for these ops (or which attribute combinations are not supported). It would be easiest to set up node tests for your torch-mlir build by cloning nod-ai/SHARK-TestSuite, navigating to alt_e2eshark and setting up with the instructions in the README.md. Then run python run.py -m cl-onnx-iree -v -t test_deq or test_cast to run the onnx node tests.
  3. Find the torch-onnx-to-torch conversion logic in torch-mlir (under lib/Conversion/TorchOnnxToTorch/).
  4. Figure out what is going wrong and try to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants