Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Feedback on Toolpad Core mention in MUI templates #4543

Open
prakhargupta1 opened this issue Dec 17, 2024 · 2 comments
Open

[docs] Feedback on Toolpad Core mention in MUI templates #4543

prakhargupta1 opened this issue Dec 17, 2024 · 2 comments
Labels
docs Improvements or additions to the documentation

Comments

@prakhargupta1
Copy link
Member

prakhargupta1 commented Dec 17, 2024

Related page

https://mui.com/material-ui/getting-started/templates/#toolpad-core-beta

Issue description

Olivier's feedback on mui/material-ui#44415

  1. These redirects should be in Toolpad repository.
  2. Wrong light mode image size.
    Note: I rechecked the dark and light images, and the size is same. I can't figure out what's wrong.
  3. https://github.com/mui/material-ui/pull/44415/files#diff-6c8074cc0cbdc7ebecdca83a8bffea83d4b53608423228e56f0acbf9e050de80R27 to be moved under callout.
@prakhargupta1 prakhargupta1 added the docs Improvements or additions to the documentation label Dec 17, 2024
@bharatkashyap
Copy link
Member

  1. These redirects should be in Toolpad repository.

I added these redirects on the Toolpad docs website but that alone wasn't enough to make the https://mui.com level redirection work: https://mui.com/toolpad/core/templates/nextjs-dashboard still returned a 404 page.

  1. Wrong light mode image size.
    Note: I rechecked the dark and light images, and the size is same. I can't figure out what's wrong.

👍🏻

  1. https://github.com/mui/material-ui/pull/44415/files#diff-6c8074cc0cbdc7ebecdca83a8bffea83d4b53608423228e56f0acbf9e050de80R27 to be moved under callout.

It's already under the callout, isnt it?

@prakhargupta1
Copy link
Member Author

It's already under the callout, isnt it?

Sorry, I think it was that the callout should be below: 'If you see any room for improvement, please feel free to open an issue or a pull request on GitHub.'

@oliviertassinari can you confirm?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

No branches or pull requests

2 participants