-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider not asking user for perf information where "Performance Impact: --- → none" #2444
Comments
Thank you for your suggestion. It makes sense to me. @julienw, could you please confirm if this is OK for you? |
I agree regarding not setting a needinfo when the field gets set to none, but @davehunt might also have some thoughts on this. |
Sorry I missed the previous ping. This makes sense, but I also think this will be rare enough that we don't need to special-case this. Or have you seen this a lot @mayankleoboy ? |
Only experienced it once. |
It'd be super quick to fix this, so we might as well just do it. Just need to add a parameter to the query at bugbot/bugbot/rules/moved_to_performance.py Line 140 in 0d7c874
|
Ref: https://bugzilla.mozilla.org/show_bug.cgi?id=1907002
Here, the bug was moved to Core:Performance. However, the "Performance impact" flag was set to "None"
In such scenario, consider not triggering the automated needinfo asking the reportee for performance measurements.
The text was updated successfully, but these errors were encountered: