Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider not asking user for perf information where "Performance Impact: --- → none" #2444

Open
mayankleoboy opened this issue Jul 12, 2024 · 6 comments

Comments

@mayankleoboy
Copy link

Ref: https://bugzilla.mozilla.org/show_bug.cgi?id=1907002

Here, the bug was moved to Core:Performance. However, the "Performance impact" flag was set to "None"

In such scenario, consider not triggering the automated needinfo asking the reportee for performance measurements.

@suhaibmujahid
Copy link
Member

Thank you for your suggestion. It makes sense to me.

@julienw, could you please confirm if this is OK for you?

@suhaibmujahid suhaibmujahid transferred this issue from mozilla/bugbug Jul 12, 2024
@suhaibmujahid suhaibmujahid changed the title Consider not asking user for perf information where "Performance Impact: --- → none". (Bug 1907002) Consider not asking user for perf information where "Performance Impact: --- → none" Jul 12, 2024
@marco-c
Copy link
Contributor

marco-c commented Oct 30, 2024

Ping @julienw @gmierz

@gmierz
Copy link
Contributor

gmierz commented Oct 30, 2024

I agree regarding not setting a needinfo when the field gets set to none, but @davehunt might also have some thoughts on this.

@julienw
Copy link

julienw commented Oct 31, 2024

Sorry I missed the previous ping.

This makes sense, but I also think this will be rare enough that we don't need to special-case this. Or have you seen this a lot @mayankleoboy ?

@mayankleoboy
Copy link
Author

Only experienced it once.

@marco-c
Copy link
Contributor

marco-c commented Oct 31, 2024

It'd be super quick to fix this, so we might as well just do it. Just need to add a parameter to the query at

.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants