Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings Not Closable in Quake Mode #13518

Closed
say25 opened this issue Jul 15, 2022 · 5 comments
Closed

Settings Not Closable in Quake Mode #13518

say25 opened this issue Jul 15, 2022 · 5 comments
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Milestone

Comments

@say25
Copy link

say25 commented Jul 15, 2022

Windows Terminal version

1.15.1862.0

Windows build number

10.0.19044.0

Other Software

No response

Steps to reproduce

  1. Open Quake Mode
  2. Open settings (CTRL + ,)
  3. Try to close settings

Expected Behavior

Ability to close settings

Actual Behavior

Quake mode is basically unusable now

@say25 say25 added the Issue-Bug It either shouldn't be doing this or needs an investigation. label Jul 15, 2022
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jul 15, 2022
@DHowett
Copy link
Member

DHowett commented Jul 16, 2022

Ah, good call. Thanks for the report. For a quick fix, you should be able to close it like any other tab with Ctrl+Shift+W or switch away from it with Ctrl+Tab.

@zadjii-msft zadjii-msft added the Needs-Discussion Something that requires a team discussion before we can proceed label Jul 18, 2022
@zadjii-msft
Copy link
Member

Marking this up for discussion because I don't know what the good fix for this is.

@zadjii-msft zadjii-msft added the Product-Terminal The new Windows Terminal. label Jul 18, 2022
@carlos-zamora
Copy link
Member

(Sync meeting notes)
Proposing these as options (not edicts):

  • if there's multiple tabs, show tab bar focus-lite mode
  • if there's a settings tab, show tab bar

Short-term:

#7210

Long-term:

#5677

@carlos-zamora carlos-zamora added Area-UserInterface Issues pertaining to the user interface of the Console or Terminal and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements Needs-Discussion Something that requires a team discussion before we can proceed labels Jul 25, 2022
@carlos-zamora carlos-zamora added this to the Backlog milestone Jul 25, 2022
@zadjii-msft
Copy link
Member

Great, so sounds like we can close this one as a combo dupe?

@carlos-zamora
Copy link
Member

Great, so sounds like we can close this one as a combo dupe?

Oh yeah, good point.

@carlos-zamora carlos-zamora closed this as not planned Won't fix, can't repro, duplicate, stale Jul 25, 2022
@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

4 participants