-
Notifications
You must be signed in to change notification settings - Fork 895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] parse of BUILD_INFO failed if not set #3837
Comments
The requirement of this ENV should be documented or made optional. |
Hi, we're sending this friendly reminder because we haven't heard back from you in 30 days. We need more information about this issue to help address it. Please be sure to give us your input. If we don't hear back from you within 7 days of this comment, the issue will be automatically closed. Thank you! |
Up. What kind of information do you need? |
The source code of Inside this repository, there is already a fix to fall back to a default value if promptflow/src/promptflow-core/promptflow/core/_serving/v1/app.py Lines 134 to 139 in 40c84b4
The fix is very easy. Is there another way to ask for a fix? |
Describe the bug
With a fresh environment on my computer, my flow raises an error with the tool
promptflow_vectordb.tool.common_index_lookup.search
.The function
_get_custom_dimensions
insidepromptflow_vectordb\tool\common_index_lookup.py
cannot get abuild_number
because the environment variableBUILD_INFO
is not set.How To Reproduce the bug
Steps to reproduce the behavior, how frequent can you experience the bug:
promptflow_vectordb.tool.common_index_lookup.search
with a FAISS index from Azure ML (I didn't test with other options)Expected behavior
The index lookup has to work without the
BUILD_INFO
. It has to have fallbackbuild_number
if the environment variable is not set.Running Information(please complete the following information):
pf -v
:python --version
: python==3.11.10Additional context
There are discussions at #3632 with this error, but it was not the main topic and the issue is closed.
The text was updated successfully, but these errors were encountered: