Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] parse of BUILD_INFO failed if not set #3837

Open
vsantele opened this issue Oct 30, 2024 · 4 comments
Open

[BUG] parse of BUILD_INFO failed if not set #3837

vsantele opened this issue Oct 30, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@vsantele
Copy link

Describe the bug
With a fresh environment on my computer, my flow raises an error with the tool promptflow_vectordb.tool.common_index_lookup.search.
The function _get_custom_dimensions inside promptflow_vectordb\tool\common_index_lookup.py cannot get a build_number because the environment variable BUILD_INFO is not set.

How To Reproduce the bug
Steps to reproduce the behavior, how frequent can you experience the bug:

  1. Create a conda environment with python=3.11
  2. Install the lastest version of promptflow (1.16.1), promptflow-tools (1.4.0) and promptflow-vectordb (0.2.13)
  3. Create a flow using promptflow_vectordb.tool.common_index_lookup.search with a FAISS index from Azure ML (I didn't test with other options)
  4. Run the flow

Expected behavior
The index lookup has to work without the BUILD_INFO. It has to have fallback build_number if the environment variable is not set.

Running Information(please complete the following information):

  • Promptflow Package Version using pf -v:
{
  "promptflow": "1.16.1",
  "promptflow-azure": "1.16.1",
  "promptflow-core": "1.16.1",
  "promptflow-devkit": "1.16.1",
  "promptflow-tracing": "1.16.1"
}
promtflow-vectordb===0.2.13
promptflow-tools===1.4.0
  • Operating System: Windows 11
  • Python Version using python --version: python==3.11.10

Additional context
There are discussions at #3632 with this error, but it was not the main topic and the issue is closed.

@vsantele vsantele added the bug Something isn't working label Oct 30, 2024
@ferronsw
Copy link

ferronsw commented Nov 7, 2024

The requirement of this ENV should be documented or made optional.
I've spend to many hours on finding this problem. I think many others with me.

Copy link

github-actions bot commented Dec 7, 2024

Hi, we're sending this friendly reminder because we haven't heard back from you in 30 days. We need more information about this issue to help address it. Please be sure to give us your input. If we don't hear back from you within 7 days of this comment, the issue will be automatically closed. Thank you!

@github-actions github-actions bot added the no-recent-activity There has been no recent activity on this issue/pull request label Dec 7, 2024
@vsantele
Copy link
Author

vsantele commented Dec 8, 2024

Up. What kind of information do you need?

@github-actions github-actions bot removed the no-recent-activity There has been no recent activity on this issue/pull request label Dec 8, 2024
@vsantele
Copy link
Author

The source code of promptflow-vectordb is not available. So we cannot fix or make a PR for this.

Inside this repository, there is already a fix to fall back to a default value if BUILD_INFO is not set up.

build_info = os.environ.get("BUILD_INFO", "")
try:
build_info_dict = json.loads(build_info)
version = build_info_dict["build_number"]
except Exception:
version = __version__

The fix is very easy. Is there another way to ask for a fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants