Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialization of accessRequest.content property #93

Open
zengin opened this issue Jun 5, 2024 · 0 comments
Open

Serialization of accessRequest.content property #93

zengin opened this issue Jun 5, 2024 · 0 comments

Comments

@zengin
Copy link

zengin commented Jun 5, 2024

Current implementation does not reflect the following spec:

          > Should we rename [accessRequest.content](https://github.com/microsoft/OpenApi.ApiManifest/blob/96b16a2c710e44765d12ae39c50b2b7b2410e4e0/src/lib/AccessRequest.cs#L13) to accessRequest.actions to match RAR's authorization_details?

No. Content represents the entire object. Actions is only a potential suggestion of a property name within the RAR. The content of the RAR can be anything. The only required field is type. I see now that the object model that I created makes the assumption that there will be a property called content, but that isn't in the spec. I think what we should do is have the content property in C# contain the entire object in Authorization Details array, and we should just pull the Type property out from within the parsed Content object. We will be holding the Type redundantly but I think that is ok.

Originally posted by @darrelmiller in #7 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant