You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Current implementation does not reflect the following spec:
> Should we rename [accessRequest.content](https://github.com/microsoft/OpenApi.ApiManifest/blob/96b16a2c710e44765d12ae39c50b2b7b2410e4e0/src/lib/AccessRequest.cs#L13) to accessRequest.actions to match RAR's authorization_details?
No. Content represents the entire object. Actions is only a potential suggestion of a property name within the RAR. The content of the RAR can be anything. The only required field is type. I see now that the object model that I created makes the assumption that there will be a property called content, but that isn't in the spec. I think what we should do is have the content property in C# contain the entire object in Authorization Details array, and we should just pull the Type property out from within the parsed Content object. We will be holding the Type redundantly but I think that is ok.
Current implementation does not reflect the following spec:
No. Content represents the entire object. Actions is only a potential suggestion of a property name within the RAR. The content of the RAR can be anything. The only required field is
type
. I see now that the object model that I created makes the assumption that there will be a property calledcontent
, but that isn't in the spec. I think what we should do is have thecontent
property in C# contain the entire object in Authorization Details array, and we should just pull the Type property out from within the parsed Content object. We will be holding the Type redundantly but I think that is ok.Originally posted by @darrelmiller in #7 (comment)
The text was updated successfully, but these errors were encountered: