Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2 - get rid of OpenApiReaderRegistry #2022

Open
baywet opened this issue Dec 20, 2024 · 1 comment
Open

v2 - get rid of OpenApiReaderRegistry #2022

baywet opened this issue Dec 20, 2024 · 1 comment
Labels
type:bug A broken experience
Milestone

Comments

@baywet
Copy link
Member

baywet commented Dec 20, 2024

Having a static instance with concurrent dictionaries is going to at best negatively impact performance, at worst introduce race conditions.

In addition to that, the API itself it not obvious.

All the places where we call "GetReader" from, are places where we have access to the settings.

I suggest we nuke that class and make the readers a property of the settings class instead, with defaults.

@baywet baywet added the type:bug A broken experience label Dec 20, 2024
@baywet baywet added this to the v2 - Preview4 milestone Dec 20, 2024
@darrelmiller
Copy link
Member

I'm fine with removing the static instance, as long as we are not losing any functionality. Using reader settings seems fine to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug A broken experience
Projects
None yet
Development

No branches or pull requests

2 participants