We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Having a static instance with concurrent dictionaries is going to at best negatively impact performance, at worst introduce race conditions.
In addition to that, the API itself it not obvious.
All the places where we call "GetReader" from, are places where we have access to the settings.
I suggest we nuke that class and make the readers a property of the settings class instead, with defaults.
The text was updated successfully, but these errors were encountered:
I'm fine with removing the static instance, as long as we are not losing any functionality. Using reader settings seems fine to me.
Sorry, something went wrong.
No branches or pull requests
Having a static instance with concurrent dictionaries is going to at best negatively impact performance, at worst introduce race conditions.
In addition to that, the API itself it not obvious.
All the places where we call "GetReader" from, are places where we have access to the settings.
I suggest we nuke that class and make the readers a property of the settings class instead, with defaults.
The text was updated successfully, but these errors were encountered: