Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assertion failure when there are more than 255 tokenized data files (assert num_datasets < 255 in blendable_dataset.py) #377

Open
Jeronymous opened this issue Apr 17, 2024 · 0 comments

Comments

@Jeronymous
Copy link

I am hitting this assertion:

  File ".../Megatron-DeepSpeed/megatron/data/blendable_dataset.py", line 36, in _build_indices
    assert num_datasets < 255

I am then wondering why something like what is done in this PR was not merged?

-            assert num_datasets < 255
-            dataset_index = np.zeros(self.size, dtype=np.uint8)
+            # assert num_datasets < 255
+            dataset_index = np.zeros(self.size, dtype=np.int64)

Is there a performance issues if the user have thousands of tokenized files (instead of a few dozens)?

Also, to workaround this limitation, is there a script somewhere to concatenate several ".bin" and ".idx" files (with tokenized text inside)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant