Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom 3D layer disappears with higher pitch values #5222

Open
kaij opened this issue Dec 16, 2024 · 3 comments
Open

Custom 3D layer disappears with higher pitch values #5222

kaij opened this issue Dec 16, 2024 · 3 comments
Labels
globe Globe related issues need more info Further information is requested terrain

Comments

@kaij
Copy link

kaij commented Dec 16, 2024

It seems that layers randomly disappear with high pitch values (see video). Is there any known workaround? Note: also other layers seem to vanish (e.g. name of the roads).

What can also be seen is that the name of the roads is duplicated too many times (the higher the pitch, the more often the road name is displayed). Also, the roads seem to get larger than usual with higher pitches.

maplibre-gl-js version: 5.0.0-pre9

browser: chrome, firefox, safari

Steps to Trigger Behavior

  1. use map with terrain and custom 3d layer
  2. pitch or flyTo with high target pitch (80-90deg)

Layers get hidden

Link to Demonstration

layer-visibility.mov

Expected Behavior

Layer stays visible independent of pitch value

Actual Behavior

Layer disappears with higher pitch values

@HarelM
Copy link
Collaborator

HarelM commented Dec 16, 2024

This might be related to near and far z which were recently fixed, can you check with the latest version in main?

@HarelM HarelM added need more info Further information is requested terrain globe Globe related issues labels Dec 16, 2024
@kaij
Copy link
Author

kaij commented Dec 17, 2024

It does not work with the most recent main branch. I think it's a problem with specific rendering of a map layer layer. If I remove the layers 'Road labels' and 'Road number labels', it works much better.

However, there is still a massive distortion of features with high pitch values, the roads will bleed into the houses... as can be seen at https://www.bilder-der-schweiz.online/en/node/83#nb-482048. This is something new with the v5 branch (possibly recent commits).

Image

Image

@HarelM
Copy link
Collaborator

HarelM commented Dec 17, 2024

There was a change in the tile loading strategy as part of version 5 and it might affect this view of high pitch, IDK, you can check the changelog and relevant versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
globe Globe related issues need more info Further information is requested terrain
Projects
None yet
Development

No branches or pull requests

2 participants