Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace autocomplete="off" with autocomplete="one-time-code" on auth #332

Open
JamesFX2 opened this issue Sep 18, 2023 · 1 comment
Open

Comments

@JamesFX2
Copy link

Hi,

https://web.dev/sms-otp-form/ recommends that autocomplete="off" is replaced with autocomplete="one-time-code" so that the browser doesn't ask the user if they want to replace their current password with the autocomplete.

See also https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/autocomplete#values

For example,

https://github.com/magento/security-package/blob/develop/TwoFactorAuth/view/adminhtml/web/template/google/auth.html#L25

Can submit a PR myself with "fixes" if requested.

@m2-assistant
Copy link

m2-assistant bot commented Sep 18, 2023

Hi @JamesFX2. Thank you for your report.
To speed up processing of this issue, make sure that you provided sufficient information.
Add a comment to assign the issue: @magento I am working on this


Join Magento Community Engineering Slack and ask your questions in #github channel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant