Create a new section highlighting contributor and user badges #6119
Conversation
Signed-off-by: Souvik Kar Mahapatra <[email protected]>
…section-community-page
|
🚀 Preview for commit 972e198 at: https://6757d9749cd366ae3c2540a2--layer5.netlify.app |
|
@souvikinator adding it as an agenda item to the meeting minutes. |
| } | ||
| } | ||
| @media (max-width: 62rem) { |
There was a problem hiding this comment.
be consistent in using either rem or px
| @@ -260,6 +260,115 @@ const CommunitySectionWrapper = styled.div` | |||
| } | |||
| } | |||
| .recognition-program { | |||
There was a problem hiding this comment.
why defining styles again ? is there no styles to reuse from this page?
There was a problem hiding this comment.
Updated the styles. Removed redundant style definitions and used similar style definitions from other sections. Only styles related to badge alignment and responsiveness is there as it is specific to this section.
There was a problem hiding this comment.
@souvikinator i was mentioning to use reuse the styles which means the classnames if the other section have the same structure so in that way you don't have to write styles again. I am sure in this page only there might be jumbotrons so see if you can use there classes instead writing again.
|
@souvikinator calling again. Please add it as an agenda item to the meeting minutes. |
…rogram-section-community-page
|
🚀 Preview for commit b8c6e8a at: https://676b3e11da0e8e6a0c51fc4c--layer5.netlify.app |
| @@ -260,6 +260,115 @@ const CommunitySectionWrapper = styled.div` | |||
| } | |||
| } | |||
| .recognition-program { | |||
There was a problem hiding this comment.
@souvikinator i was mentioning to use reuse the styles which means the classnames if the other section have the same structure so in that way you don't have to write styles again. I am sure in this page only there might be jumbotrons so see if you can use there classes instead writing again.
Description
This PR fixes #6092
Changes made:
Desktop view:
Mobile view:
Notes for Reviewers
Signed commits