LimitRange.Spec.Limits omitempty

[colinhoglund]

It seems like the following field should probably omitempty, so that json.Unmarshal of an empty LimitRange doesn't zero out non-empty Limits.

api/core/v1/types.go

Line 7010 in 71385f0

Limits []LimitRangeItem `json:"limits" protobuf:"bytes,1,rep,name=limits"`

Is there any reason this is not omitempty? If not, does it make sense to open a PR to change this?

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle stale
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale