Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the new 'go tool' features to track tool versions (go 1.24) #4412

Open
schrej opened this issue Dec 6, 2024 · 1 comment
Open

Use the new 'go tool' features to track tool versions (go 1.24) #4412

schrej opened this issue Dec 6, 2024 · 1 comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@schrej
Copy link
Member

schrej commented Dec 6, 2024

What do you want to happen?

Go 1.24 will introduce a new feature that allows to track tool versions using go.mod: golang/go#48429

It adds a new tool directive to go.mod to specify the versions of tools to use, which can then be used with go tool <name>. We should evaluate whether we can use this new feature to track the various tools that are used by kubebuilder including kustomize and everything in controller-tools instead of the custom logic that's currently implemented in the Makefile.

We'll have to wait until 1.24 is released and adopted of course, so for now this issue primarily serves as a reminder.

Extra Labels

No response

@schrej schrej added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 6, 2024
@camilamacedo86
Copy link
Member

Hi @schrej

That is great. We need wait controller-runtime, k8s releases versions with go 1.24 to this one
But if you want to create a PR with a proposed solution please feel free
We might want a design doc as well: https://github.com/kubernetes-sigs/kubebuilder/tree/master/designs

However, I would first recommend a POC with the proposed changes
Then we see if the more detailed discussion is required or not for the doc etc
The proposal would indeed use the PR, anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants