DNSEndpoint CRD Renaming

[6ixfalls]

Hi, I'm trying to setup two seperate external-dns instances which both use the DNSEndpoint CRD. I want to have a different resource for each instance, one for ExternalDNSEndpoints, and one for InternalDNSEndpoints. I've tried changing the argument "--crd-source-kind" to ExternalDNSEndpoint and InternalDNSEndpoint respectively, as well as editing the spec for the DNSEndpoint CRD. However, the external-dns deployment (pod) fails to start, with the error no kind \"ExternalDNSEndpointList\" is registered for version \"externaldns.k8s.io/v1alpha1\" in scheme \"pkg/runtime/scheme.go:100\". I don't see a reference to this in any other config. I've also looked at labelFilter, but that also affects other sources, which I don't want - I only want to filter for CRDs. How would I have the different external-dns instances have different DNSEndpoints?

[alex-bezek]

Hello, I am also trying to do something similar and change the CRD kind and am getting the same no kind for the List error. I noticed this issue and slack conversation that predates this #2308 . The comments seemed to suggest they were working on a dynamic client to fix this. The issue was closed as stale, but the code does appear to use a discovery client now and register the scheme

external-dns/source/crd.go

Lines 64 to 108 in 4033eec

	func NewCRDClientForAPIVersionKind(client kubernetes.Interface, kubeConfig, apiServerURL, apiVersion, kind string) (*rest.RESTClient, *runtime.Scheme, error) {
	if kubeConfig == "" {
	if _, err := os.Stat(clientcmd.RecommendedHomeFile); err == nil {
	kubeConfig = clientcmd.RecommendedHomeFile
	}
	}
	config, err := clientcmd.BuildConfigFromFlags(apiServerURL, kubeConfig)
	if err != nil {
	return nil, nil, err
	}
	groupVersion, err := schema.ParseGroupVersion(apiVersion)
	if err != nil {
	return nil, nil, err
	}
	apiResourceList, err := client.Discovery().ServerResourcesForGroupVersion(groupVersion.String())
	if err != nil {
	return nil, nil, fmt.Errorf("error listing resources in GroupVersion %q: %w", groupVersion.String(), err)
	}
	var crdAPIResource *metav1.APIResource
	for _, apiResource := range apiResourceList.APIResources {
	if apiResource.Kind == kind {
	crdAPIResource = &apiResource
	break
	}
	}
	if crdAPIResource == nil {
	return nil, nil, fmt.Errorf("unable to find Resource Kind %q in GroupVersion %q", kind, apiVersion)
	}
	scheme := runtime.NewScheme()
	addKnownTypes(scheme, groupVersion)
	config.ContentConfig.GroupVersion = &groupVersion
	config.APIPath = "/apis"
	config.NegotiatedSerializer = serializer.WithoutConversionCodecFactory{CodecFactory: serializer.NewCodecFactory(scheme)}
	crdClient, err := rest.UnversionedRESTClientFor(config)
	if err != nil {
	return nil, nil, err
	}
	return crdClient, scheme, nil
	}

I do see in the code it explicitly registers both the DNSEndpoint and DNSEndpointList kinds https://github.com/kubernetes-sigs/external-dns/blob/master/source/crd.go#L56-L57 . It seems like it may need to add the list kind to the scheme as well.

Can someone let me know if we can work through fixing this here or if we should log a new issue? Thanks