Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate krel obs into the release process #1248

Open
saschagrunert opened this issue Aug 21, 2023 · 20 comments
Open

Integrate krel obs into the release process #1248

saschagrunert opened this issue Aug 21, 2023 · 20 comments
Assignees
@xmudrii
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/node Categorizes an issue or PR as relevant to SIG Node.

Comments

@saschagrunert
Copy link
Member

saschagrunert commented Aug 21, 2023 •
edited
Loading

First of all we have to publish the release artifacts to the Google Cloud Bucket:

kpromo gh --org kubernetes-sigs --repo cri-tools --bucket k8s-artifacts-cri-tools --release-dir release --tags v1.28.0

Publishes the GitHub artifacts in https://console.cloud.google.com/storage/browser/k8s-artifacts-cri-tools/release

Then we need to run the following commands to release cri-tools in OBS:

krel obs stage --packages cri-tools --version 1.28.0 --project isv:kubernetes:core:stable:v1.28:build --stream --nomock

Runs a Google Cloud Build job and stages:
https://build.opensuse.org/package/show/isv:kubernetes:core:stable:v1.28:build/cri-tools

krel obs release --packages cri-tools --stream --project isv:kubernetes:core:stable:v1.28:build --nomock

Runs a Google Cloud Build job and releases:
https://build.opensuse.org/package/show/isv:kubernetes:core:stable:v1.28/cri-tools.20230814075509

Goal is to integrate the steps above into our release workflow, containing the right amount of permissions:
https://github.com/kubernetes-sigs/cri-tools/blob/master/.github/workflows/release.yml

@kubernetes-sigs/release-engineering we need:

  • OBS credentials to run krel obs
  • A service account token to access k8s-artifacts-cri-tools
@saschagrunert saschagrunert added kind/feature Categorizes issue or PR as related to a new feature. sig/node Categorizes an issue or PR as relevant to SIG Node. labels Aug 21, 2023
@xmudrii
Copy link
Member

xmudrii commented Aug 23, 2023

I can help with this. I'll add this issue to our project board so that we properly follow it.

@xmudrii xmudrii moved this to 🔖 Backlog in SIG Release - Packaging Aug 23, 2023
@afbjorklund
Copy link
Contributor

Shouldn't this be in kubernetes-release, rather than cri-tools ?

@saschagrunert
Copy link
Member Author

The automation will happen in this repository, we can also consider moving the specfile here.

@saschagrunert
Copy link
Member Author

@kubernetes-sigs/release-engineering how about:

  1. Creating a bot account similar to CRI-O to be able to publish packages for cri-tools
  2. Move the specfile into this repository
  3. Create an publish them similar to https://github.com/cri-o/packaging, but triggered by tags as part of this GitHub action: https://github.com/kubernetes-sigs/cri-tools/blob/master/.github/workflows/release.yml

@xmudrii
Copy link
Member

xmudrii commented Oct 11, 2023

@saschagrunert I think this is a solid plan. I would only try to avoid having a new repo for packaging (because getting repos in k or k-sigs is a more complicated process and it's not scalable).

@saschagrunert
Copy link
Member Author

saschagrunert commented Oct 11, 2023 •
edited
Loading

@xmudrii I'd like to try a full automation here, means we would require a service account being able to push to https://console.cloud.google.com/storage/browser/k8s-artifacts-cri-tools. Can we create on in kubernetes/k8s.io?

@xmudrii
Copy link
Member

xmudrii commented Oct 11, 2023

@saschagrunert Yes, please create an issue in k/k8s.io to track getting a new service account.

@saschagrunert
Copy link
Member Author

@xmudrii closing the loop: kubernetes/k8s.io#5957

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 30, 2024
@saschagrunert
Copy link
Member Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 30, 2024
@saschagrunert
Copy link
Member Author

We still need this, and could also think about proposing an automated vendor PR for the RC of a new Kubernetes version. This could include a hint that we may want to cut a release afterwards.

@saschagrunert saschagrunert mentioned this issue Apr 18, 2024
Open
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 17, 2024
@xmudrii
Copy link
Member

xmudrii commented Jul 23, 2024

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 23, 2024
@saschagrunert
Copy link
Member Author

@xmudrii do you plan to work in this before v1.31 get's released?

@xmudrii
Copy link
Member

xmudrii commented Jul 23, 2024

@saschagrunert Yes, I'll be looking into this issue this week.
/assign

@saschagrunert
Copy link
Member Author

Let me know if you need anything, would be awesome to deliver it this cycle.

@saschagrunert
Copy link
Member Author

@xmudrii I'm planning to release cri-tools v1.31 this week. Do we still want to invest in automation or plan that for 1.32?

@xmudrii
Copy link
Member

xmudrii commented Aug 27, 2024

It's on my TODO list and we'll have it in place for v1.32. :shipit: Sorry for delay!

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 25, 2024
@xmudrii
Copy link
Member

xmudrii commented Nov 26, 2024

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xmudrii xmudrii

Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/node Categorizes an issue or PR as relevant to SIG Node.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@saschagrunert @afbjorklund @xmudrii @k8s-ci-robot @k8s-triage-robot