Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing manager featureGates for Bootstrap and ControlPlane Providers #633

Open
gcezaralmeida opened this issue Nov 7, 2024 · 2 comments · May be fixed by #634
Open

Missing manager featureGates for Bootstrap and ControlPlane Providers #633

gcezaralmeida opened this issue Nov 7, 2024 · 2 comments · May be fixed by #634
Labels
kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@gcezaralmeida
Copy link

What steps did you take and what happened:
It is missing the logic to add the manager.featureGates to the bootstrapProvider and controlplaneProvider in helm template files. In the latest release this can be done only for coreProvider and infraProvider.

E.g.

...
manager:
  featureGates:
    core:
       KubeadmBootstrapFormatIgnition: true 
     bootstrap:                                                     # This one is missing from the template
       KubeadmBootstrapFormatIgnition: true 
     controlplane:                                                 # This one is missing from the template
       KubeadmBootstrapFormatIgnition: true 
...

What did you expect to happen:
Add those manager features gates to the provider Bootstrap and ControlPlane providers.

Anything else you would like to add:
I want to contribute to this fix. I will create a PR for this.

Environment:

  • Cluster-api-operator version: 0.14.0
  • Cluster-api version: 1.8.4
  • Minikube/KIND version:
  • Kubernetes version: (use kubectl version): Any
  • OS (e.g. from /etc/os-release):

/kind bug
[One or more /area label. See https://github.com/kubernetes-sigs/cluster-api-operator/labels?q=area for the list of labels]
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 7, 2024
@furkatgofurov7
Copy link
Member

/triage accepted
@gcezaralmeida feel free to assign this and tag me once you open a PR, thanks!

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 7, 2024
@gcezaralmeida gcezaralmeida linked a pull request Nov 7, 2024 that will close this issue
Open
@jnull
Copy link

jnull commented Nov 27, 2024

I got it working by setting the following:
In your value.yaml:

...
manager:
  featureGates:
    core:
      ClusterTopology: "true"
      ClusterResourceSet: "true"
      KubeadmBootstrapFormatIgnition: "true"
configSecret:
  name: config-vars
  namespace: default
...

And creating a config secret beforehand:

apiVersion: v1
kind: Secret
metadata:
  name: config-vars
  namespace: default
type: Opaque
stringData:
  CLUSTER_TOPOLOGY: "true"
  EXP_KUBEADM_BOOTSTRAP_FORMAT_IGNITION: "true"
  BOOTSTRAP_FORMAT_IGNITION: "true"

With that the bootstrap and control-plane provider will take the secret as config and set the correct feature-gates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🐛 Extend helm feature gates gcezaralmeida/cluster-api-operator
4 participants
@k8s-ci-robot @gcezaralmeida @jnull @furkatgofurov7