Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

result.replace("\n", "\r\n") for KdlDocument::to_string on Windows #64

Open
dj8yfo opened this issue Jun 15, 2023 · 2 comments
Open

result.replace("\n", "\r\n") for KdlDocument::to_string on Windows #64

dj8yfo opened this issue Jun 15, 2023 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@dj8yfo
Copy link

dj8yfo commented Jun 15, 2023 •
edited
Loading

This might be a problem if files are generated from KdlDocument-s .
If you chose to never ever support Windows, you'd find my deep empathy and understanding.
@zkat
Copy link
Member

zkat commented Jun 29, 2023

This should be functionality as part of KdlDocument::fmt &co. Since they're not configurable, I think a good default is "detect existing newlines and use the first one you find. Otherwise, if there's no newlines yet, use the current OS' native newlines".

@zkat zkat added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Jun 29, 2023
@zkat
Copy link
Member

zkat commented Dec 3, 2024

Update: This is related to #85 and should probably use the same strategy: allowing newline configuration with a FormatConfig object.

@zkat zkat mentioned this issue Dec 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zkat @dj8yfo