Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposing django-voting #136

Closed
5 tasks
PiDelport opened this issue Mar 13, 2019 · 13 comments
Closed
5 tasks

Proposing django-voting #136

PiDelport opened this issue Mar 13, 2019 · 13 comments
Labels

Comments

@PiDelport
Copy link
Member

As explained in jazzband/django-voting#13, I'm no longer using or actively maintaining this package, and @stephendwolff expressed interest in helping to get it in shape for Jazzband.

Guidelines criteria:

To do:

  • Conduct
  • Contributing Guidelines
  • Badges

To transfer to Jazzband:

@PiDelport
Copy link
Member Author

I may have jumped the gun here: I thought requesting the transfer would just request it, and have the Jazzband bot take some actions… but the repo is transferred now.

Is that okay?

@jezdez
Copy link
Member

jezdez commented Mar 13, 2019

Hmm, somethng went wrong during the transfer with the webhooks.. investigating.

As an aside, have you reached out to @brosner about transferring the original project? I'm not a fan of us maintaining forks, since that kind of defeats the purpose :-/

@stephendwolff
Copy link

I think the original project has been archived: https://code.google.com/archive/p/django-voting/#! and never got past about Django 1.1.
I just stepped in with a PR to get it working with Django 1.11 (from 1.8 or so). It would need another update to get it up to the current LTS i think

@jezdez
Copy link
Member

jezdez commented Mar 13, 2019

Sure, what I'm saying is that we can ask @brosner to do the transfer, then push the changes in @PiDelport's fork into that repo. Or maybe ask GitHub support to remove the fork boolean.

@stephendwolff
Copy link

Ah - i hadn't realised @PiDelport's was a fork - as it is published on PyPI

@jezdez
Copy link
Member

jezdez commented Mar 13, 2019

It's probably from a time when repos weren't allowed to be transferred.

@jezdez
Copy link
Member

jezdez commented Mar 13, 2019

Downside of using brosner's repo would be we'd loose all tickets/PRs in @PiDelport's repo. @PiDelport what do you think?

@PiDelport
Copy link
Member Author

Hmm, have probably diverged so far from @brosner's original repo that it doesn't really gain us anything to try and transfer that?

It's probably simpler to just create a fresh GitHub repo for Jazzband, and transfer the existing Git history and open branches / PRs into that. (There's not a lot to transfer.)

@jezdez: Does that sound good to you?

@jezdez
Copy link
Member

jezdez commented Mar 13, 2019

@PiDelport Yeah, that'd work for me.

@PiDelport
Copy link
Member Author

@jezdez: Okay, cool!

It doesn't look like I can transfer the repo back out of the Jazzband organisation; I assume you can? You could transfer it back to me, then we can create a new empty jazzband/django-voting and I'll push and transfer things to it?

@stephendwolff
Copy link

@jezdez, @PiDelport, I should have a bit of time to work on this in May - do i make a fork of this, then a PR for any updates necessary to get all the 'Guidelines' addressed?

@hramezani
Copy link
Member

Any update? I can work on this. what should I do?

@jezdez jezdez added the proposal label Oct 2, 2020
@jezdez
Copy link
Member

jezdez commented Mar 10, 2021

Hey friends, I'm closing this in favor of jazzband/django-voting#17. Any help to get this over the finish line is always much appreciated.

@jezdez jezdez closed this as completed Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants