Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename setProceedOnExecuteFailure to setProceedOnExecuteFailureAfterRetryExhausted #277

Open
longquanzheng opened this issue Dec 10, 2024 · 2 comments

Comments

@longquanzheng
Copy link
Contributor

longquanzheng commented Dec 10, 2024

public WorkflowStateOptionsExtension setProceedOnExecuteFailure(final Class<? extends WorkflowState> proceedingState) {

we should also check and require retry policy to be non empty .

And mark the old ones as deprecated

@lwolczynski
Copy link
Contributor

lwolczynski commented Dec 10, 2024

  • Add JavaDocs to give users a better understanding
  • If we change the naming, make it more condensed than setProceedOnExecuteFailureAfterRetryExhausted
    • idea: setProceedAfterRetryExhausted setProceedAfterRetryPolicyExhausted
  • Throw an exception when setProceedOnExecuteFailure is used without the retry policy maximumAttempts/maximumDuration...

@lwolczynski
Copy link
Contributor

setProceedOnExecuteAfterRetryPolicyExhausted
setProceedOnWaitUntilAfterRetryPolicyExhausted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants