Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possibility to extract isoyear and isoweekday (or weekday) from a timestamp column. #8989

Closed
1 task done
kajen3 opened this issue Apr 17, 2024 · 3 comments · Fixed by #9034 · May be fixed by #9003
Closed
1 task done

Possibility to extract isoyear and isoweekday (or weekday) from a timestamp column. #8989

kajen3 opened this issue Apr 17, 2024 · 3 comments · Fixed by #9034 · May be fixed by #9003
Labels
feature Features or general enhancements

Comments

@kajen3
Copy link

kajen3 commented Apr 17, 2024

Is your feature request related to a problem?

No response

What is the motivation behind your request?

I'm working on a POC to migrate from pandas to ibis. Since pandas (and also duckdb) support this, it would be great if this is possible with ibis as well.

Describe the solution you'd like

Add new methods that expose the functionality.

What version of ibis are you running?

8.0.0

What backend(s) are you using, if any?

DuckDB

Code of Conduct

  • I agree to follow this project's Code of Conduct
@kajen3 kajen3 added the feature Features or general enhancements label Apr 17, 2024
@cpcloud
Copy link
Member

cpcloud commented Apr 17, 2024

Thanks for the issue! Seems like a nice addition.

@kaijennissen kaijennissen mentioned this issue Apr 18, 2024
Open
@kaijennissen
Copy link
Contributor

kaijennissen commented Apr 18, 2024 •
edited
Loading

I don't quiet understand all of the internals, but from what I understand this should add the isoweekday functionality. However I do not understand what day_of_week in (ibis/expr/types/temporal.py) currently is supposed to do.

@cpcloud
Copy link
Member

cpcloud commented Apr 18, 2024

I commented on the PR (#9003 (comment)). Let's continue the discussion over there.

kaijennissen added a commit to kaijennissen/ibis that referenced this issue Apr 19, 2024
@kaijennissen
Merge branch 'main' into ibis-project#8989
5140993
kaijennissen added a commit to kaijennissen/ibis that referenced this issue Apr 20, 2024
@kaijennissen
Merge branch 'main' into ibis-project#8989
5d7bbba
@kaijennissen kaijennissen mentioned this issue Apr 21, 2024
Merged
@ncclementi ncclementi mentioned this issue Apr 26, 2024
Closed
10 tasks
@github-project-automation github-project-automation bot moved this from backlog to done in Ibis planning and roadmap May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature Features or general enhancements
Projects
Ibis planning and roadmap
Archived in project
Milestone
No milestone
3 participants
@cpcloud @kaijennissen @kajen3