-
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No updates until Jan 2025 #10487
Comments
Not to add to any stress, but will Angular 19 get a relatively quick version support release before that time by any chance? |
Hope so too... |
Thanks for the update @satanTime. I still use ng-mocks on daily basis as it abstracts so much of the unit test fuzz. I came here after watching the updates for NG19 and noticing how there is getting more and more attention to implementing signals. The simple fact is that ng-mocks currently prevents me from starting to use the signal input api for instance instead of the regular Input decorator. So really looking forward to updates on that part! |
@evtk ng-mocks hasn't prevented me from using signal inputs. ng-mocks simply doesn't provide any help in that area. export class MyStepComponent {
step = input.required<Step>(); beforeEach(() => {
TestBed.configureTestingModule({
providers: [MockProvider(...), MockProvider(...)],
imports: [MyStepComponent],
});
fixture = TestBed.createComponent(MyStepComponent);
sut = fixture.componentInstance;
fixture.componentRef.setInput('step', currentStep);
}); I'm not using |
Hi all. My main concern to release support of new versions is that my knowledge of changes in v18 and v19 is none, and I prefer to force developers to notice incompatibility with v19 and install ng-mocks with -f flag, so they understand what they do and what to expect, instead of saying that the lib works with v19. Unfortunately, until Jan I don't have time at all due to private hassle. |
Yeah definitely went for being |
@satanTime Understood, thanks for the response. And good luck on your private hassles. |
Will you still be able to review PRs? If yes, I will try to at least fix the logic behind standalone :) In v19 the default flipped to |
@jahusa02 if you will work on v19 support, you might be interested to look into my fork https://github.com/dmitry-stepanenko/ng-mocks/tree/ds/v19 . I managed to get standalone components to work well in v19 apps (it's a breaking change though). Package version with my changes can be installed directly from https://github.com/dmitry-stepanenko/ng-mocks/tree/v19-built The only thing that I did not figure out is how to differentiate between v19 modules and old pre-compiled ones that come from 3rd party packages, because old ones should still keep "standalone: false" by default. |
Hmmmh. If I'm not mistaken, 19 version fix seemed to be quite trivial 🤔 func.is-standalone.ts
@dmitry-stepanenko I didn’t find any version-related code either, so I assume that metadata is being used instead In another words, change is not backward compatible. |
@GipHub123 there're a few other places where the flag should be changed in order for it to kinda work, this is done in the branch I shared above. But still if the mocked component imports an npm package that doesn't use standalone components inside, test will fail |
@GipHub123 @dmitry-stepanenko |
@re-alam I reviewed the code and it's seemed to be solid / it's backward compatible (I didn't test it) 👍 Version check seemed to be quite trivial / elegant 👍 |
Good news for january ! |
Bro joined GitHub 2 weeks ago, forks 'ng-mocks', opens a PR with a fix for Angular v19. Absolute legend 😎 |
vitest support would be great. Happy new year! |
I guess you all noticed no active development of the library for several years.
It's going to change from January 2025.
Thanks to all who was patient and hasn't lost trust in ng-mocks.
The text was updated successfully, but these errors were encountered: