-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eliminate all issues with broken links #957
Comments
Probably but someone has to do it and to maintain it. It might be easier to just track 404 errors. But for that, someone needs access to logs (anonymisised) |
When developing the new publishing script for progit2 books, I used linkchecker to assert that all the internal links are indeed pointing to an existing anchor. |
@Sicaine Tracking 404 errors is a reactive way of dealing with the errors IMHO. I'd be willing to contribute to the e2e tests if we decide to go that way. I see this project already uses grunt. How hard could it be to just crawl the links and log 404s. @jnavila does it have grunt integration? I found this: https://github.com/ChrisWren/grunt-link-checker |
Adds a build matrix entry that uses the broken-link-checker node module to crawl https://git-scm.com, searching through the site recursively, and attempting all links, reporting if they succeed or fail. This should make it easier to identify broken links on the site. (Closes git#957.) Also moves the sudo: line to the top of the file for style (it's a global build matrix configuration, so it only seems right that it belongs with the other global config settings up top).
seems useful: https://github.com/endymion/link-checker |
many dead links can be found using http://www.brokenlinkcheck.com/broken-links.php#status |
I'd like to work on this, please. |
hey @Lawrence4code :) thank you for your interest! As you can see through the comments, we never investigated a solution for this problem. Do you already have any ideas on how to solve this? If not, we can try to brainstorm some possible implementation |
The site now uses lychee in its PR builds. This only checks the internal links, though, to avoid network problems causing issues to be opened. Nevertheless, it would probably make for a fine Hacktoberfest project to run it manually including external links, and then to fix those. One could start right off the bat with removing the Packtpub links, as per #1864. |
Let's just close this, there has not been enough activity to merit keeping this ticket open. If anybody wants to pick this up, it could be done by first copy/editing |
How about writing an e2e test suite which can be run by devs which programmatically click all the links on the site and log all broken links? Would it bring down all the issues with broken links on this repo seeing that eliminating broken links would then be a one time process?
The text was updated successfully, but these errors were encountered: