Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some icons doesn't have proper resolution #1039

Open
osrl opened this issue Jan 12, 2021 · 6 comments
Open

Some icons doesn't have proper resolution #1039

osrl opened this issue Jan 12, 2021 · 6 comments

Comments

@osrl
Copy link

osrl commented Jan 12, 2021

Screen Shot 2021-01-12 at 15 10 19

While custom Chrome, Android Studio and Postman icons have great resolution, the other icons look bad. I believe many icons have this problem. (I use 32 inch 2k display)

@elrumo
Copy link
Owner

elrumo commented Jan 12, 2021

Thanks for pointing it out, I've figured what the problem is. It's because of the scaling algorithm used, I've now updated it to use Bezier instead of Bilinear. This change will apply to all new icons, when time allows it I might apply it to existing ones.

Just to be sure, would you mind trying this Spark icon? I converted it using the updated scaling algorithm.
Spark Test.icns.zip

@techtheist
Copy link

@elrumo Hi! I just discovered that problem with resampling, started to prepare issue details, but there's already an issue :)
I also found old issue about same thing: #857

Hard-edged aliasing can be visible in launchpad, finder and other places. But not on dock.

Show the difference of .icns between local "Icon Maker Pro" result vs yours using icons i uploaded as example. Big Sur 11.1 4k.
Finder:
image
Launchpad:
image

Icns system preview:
icons_finder_preview_diff

Spark icon from site vs your example:
image

@osrl
Copy link
Author

osrl commented Jan 13, 2021

@elrumo your spark icon looks great now 👍

@osrl
Copy link
Author

osrl commented Jan 13, 2021

I just found out smoothscroll from @techtheist's screenshots and it's awesome :) @elrumo just an idea, Maybe you should make most downloaded sort option. It's a great way to discover new apps.

@techtheist
Copy link

Waiting for existing icons fix while my inner perfectionist getting sad 😃
Grateful for your work, elrumo!

Unnecessary example of good looking icons

image
@osrl check these apps on desktop — the result of their work is shown :)

@osrl
Copy link
Author

osrl commented Jan 14, 2021

Are they also fixed in the website? I can use telegram and transmission icons :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants