Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve exit code reporting to detect runtime crashes #1246

Open
matouskozak opened this issue Aug 5, 2024 · 0 comments
Open

Improve exit code reporting to detect runtime crashes #1246

matouskozak opened this issue Aug 5, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@matouskozak
Copy link
Member

matouskozak commented Aug 5, 2024

Currently, when app crashes and there is no exit code set, XHarness will report TCP_CONNECTION_FAILED.

// TCP errors are encounter all the time but they are not always the cause of the failure
// If the app crashed, TCP_CONNECTION_FAILED and there was not other exit code we will return TCP_CONNECTION_FAILED
if (defaultExitCode == ExitCode.APP_CRASH && tcpErrorFound)
{
return ExitCode.TCP_CONNECTION_FAILED;
}

If possible, we should distinguish between failures in establishing TCP connection (device not ready/offline) and sudden lost of connection (likely runtime crash).

E.g. https://dev.azure.com/dnceng-public/public/_build/results?buildId=764645&view=ms.vss-test-web.build-test-results-tab&runId=19449412&resultId=100007&paneView=dotnet-dnceng.dnceng-build-release-tasks.helix-test-information-tab reports
XHarness exit code: 92 (TCP_CONNECTION_FAILED) while net.dot.System.Runtime.Tests.log shows SEGFAULT at System.Threading.LazyInitializer:EnsureLockInitialized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant