Enable nullability in ArrayEditor #12675
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12675 +/- ##
===================================================
+ Coverage 76.03108% 76.03249% +0.00140%
===================================================
Files 3181 3181
Lines 639670 639670
Branches 47215 47215
===================================================
+ Hits 486348 486357 +9
+ Misses 149805 149789 -16
- Partials 3517 3524 +7
Flags with carried forward coverage won't be shown. Click here to find out more. |
| @@ -22,12 +20,12 @@ public ArrayEditor(Type type) : base(type) | |||
| /// Gets or sets the data type this collection contains. | |||
| /// </summary> | |||
| protected override Type CreateCollectionItemType() | |||
| => CollectionType?.GetElementType(); | |||
| => CollectionType?.GetElementType()!; | |||
There was a problem hiding this comment.
Please add a comment, explaining in detail why CollectionType?.GetElement()! will never return null.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Microsoft Reviewers: Open in CodeFlow