Support GPG-signing commits #465

arxanas · 2022-07-18T22:54:03Z

Some resources:

Using git2's Repository::commit_signed: How to correctly create GPG-signed commits? rust-lang/git2-rs#507. It looks like you still need to sign the commit via GPG yourself.
- Another example of signing the commit: https://blog.hackeriet.no/signing-git-commits-in-rust/
An implementation for git-revise: Add support for GPG-signed commits (#46) mystor/git-revise#73

There's a few APIs in git-branchless which are capable of creating commits:

These commands are capable of creating commits:

git move.
- Note that it can create commits in-memory or on-disk via git rebase, so both cases will have to be handled.
- The calling code is in core::rewrite::execute. We'll probably want to add some configuration to to indicate that any commits created in this way should be signed. Also CherryPickFastOptions.
git amend.
git reword.
git sync and git restack: these should be handled fairly straightforwardly by whatever changes are made to support git move.
git record: experimental command, so not a priority at the moment.
git branchless snapshot create: these commits don't need to be signed since they're not supposed to be really committed/pushed.

These data structures will probably have to be updated to carry GPG information. You should be able to add a field and then follow the compiler errors to see where should be updated to use the new field:

AmendFastOptions.
CherryPickFastOptions
ExecuteRebasePlanOptions
MoveOptions
There is no explicit data structure for Repo::create_commit options, but it would be reasonable to add one.

In the long term, it would be best to contribute GPG-signing code to https://github.com/gitext-rs/git2-ext in some capacity. Either we can contribute it directly there, or contribute it to git-branchless first and extract it afterwards.

The text was updated successfully, but these errors were encountered:

lthms · 2022-07-23T21:30:30Z

Awesome, @arxanas. Thanks a lot for this carefully written issue.

This is probably more challenging than what I had anticipated, though I am not surprise. I will take the time to review the various links you have gathered here, and give it a try at some point.

This was done based on arxanas/git-branchless#465. Unsure what to do about `cherry_pick` as that uses the rebase mechanism within libgit2.

epage · 2023-01-05T15:38:53Z

FYI I just released git2-ext v0.2 which has some of the basics of signing support implemented

A Sign trait
A commit that takes Sign
Updated reword and amend to take Sign

The only thing I didn't touch is the cherry_pick implementation as that uses git2's rebase mechanism and I don't see a way do to sign those.

epage · 2023-01-05T15:55:45Z

Also, for full git compatibility, we should try to support what is documented at https://github.com/git/git/blob/4f6db706e6ad145a9bf6b26a1ca0970bed27bb72/Documentation/config/gpg.txt

epage · 2023-01-05T18:29:19Z

I've done another release of git2-ext that re-implements git's gpg, x509, and ssh signing behavior.

The one problem with it is when the key is in a file, we do not yet correctly handle ~/. Knew that is complex enough that I didn't want to implement it myself and didn't find a crate to do it for me that was cross-platform.

hauleth · 2023-05-09T10:52:50Z

Yeah, I have just noticed that my signed commits are missing and just found that issue. It is not super urgent for me, but I wanted to know if there is timeline for this feature?

arxanas · 2023-05-12T19:45:40Z

@hauleth there are no plans to work on this. You might want to try jj instead, which has a draft PR; see the issue at jj-vcs/jj#58

hauleth · 2023-05-15T21:31:40Z

@arxanas I got used to git-branchless and I do not know if I want to test another implementation. If anything I would probably look how to implement it there. I was just curious if anyone is working on that yet. It is minor issue, but I just wondered if there are any plans for adding support for signing.

tommyip · 2023-06-01T14:14:46Z

there are no plans to work on this

@arxanas is that a "won't fix" or just no one have time to work on it? I can try to help out if it is the second case.

necauqua · 2023-06-06T21:57:30Z

@tommyip I guess you can call it a "not enough intererst to put explicit effort in" i.e. other things outweigh this for main dev(s) and they don't use gpg-signing themselves so there's little motivation.

I made the draft PR for jj - and haven't touched it since as I'm kind of busy lately 🤷
But people are happy to accept such PRs if they are well-formed :)

arxanas · 2023-06-07T02:19:17Z

@tommyip I simply have no plans to work on it for now, but I would accept a PR implementing it.

tommyip · 2023-06-07T07:54:30Z

Cool my work uses GPG-signing so I have a bit more incentive to see this implemented. No promises though 🫣.

lbjarre · 2023-11-13T09:35:51Z

Hello, this happens to be a feature I'm also really interested in since we also require signed commits.

I see that @tommyip has some work already done here. First of all, thank you for looking into it! I just wanted to check the status of your WIP, and offer my help if there is anything that is still outstanding.

tommyip · 2023-11-13T14:36:47Z

Hi @lbjarre. The WIP PR supports all the git-branchless subcommands (at least at the time of my last push), I have been using it daily without any issue. The PR just need some integration tests, which is a bit difficult since the existing test suite assumes the output from git is deterministic but that is not the case for cryptographic signatures.

You can pull and compile my branch before this get upstreamed.

hauleth · 2023-11-13T14:40:57Z

Signatures should be deterministic as well. You just need to provide some signing key as a part of test suite. @tommyip have you tested it with SSH signing as well?

tommyip · 2023-11-13T14:50:57Z

I don't quite remember if this is the actual problem - openpgp uses the current time as part of the signature generation, but there is no easy way to mock the timestamp.

And yes, SSH signing works.

necauqua · 2023-11-13T20:10:49Z

but there is no easy way to mock the timestamp

There is a hidden gpg option --faked-system-time :)
If you append an ! to the argument the clock also would stay frozen (and not tick up from the set time)

edit: and signatures are stable with it set, so that's great
in fact, would help me with implementing similar tests once I finish doing something similar for jj

claytonrcarter · 2023-11-14T01:47:39Z

there is no easy way to mock the timestamp.

I don't know the first thing about signing commits, but the test harness for this project includes a way to mock the timestamp used by git, so that commits are created w/ deterministic ids. Does the gpg signing use the same timestamp at git?

Here's the options struct: https://github.com/arxanas/git-branchless/blob/master/git-branchless-lib/src/testing.rs#L71-L74

And here's a usage example: https://github.com/arxanas/git-branchless/blob/master/git-branchless-smartlog/tests/test_smartlog.rs#L119C11-L125

augustebaum · 2024-10-04T12:09:57Z

I'd really love this feature as my work now requires signing commits!

arxanas added the enhancement New feature or request label Jul 18, 2022

arxanas mentioned this issue Jul 18, 2022

Enhancements #2

Open

27 tasks

mebsout mentioned this issue Jan 5, 2023

Support GPG-signing commits gitext-rs/git-stack#258

Closed

2 tasks

epage added a commit to epage/git2-ext that referenced this issue Jan 5, 2023

feat(ops)!: Support signing commits

1066815

This was done based on arxanas/git-branchless#465. Unsure what to do about `cherry_pick` as that uses the rebase mechanism within libgit2.

epage mentioned this issue Jan 5, 2023

feat(ops)!: Support signing commits gitext-rs/git2-ext#22

Merged

epage added a commit to epage/git2-ext that referenced this issue Jan 5, 2023

feat(ops)!: Support signing commits

eb0a066

This was done based on arxanas/git-branchless#465. Unsure what to do about `cherry_pick` as that uses the rebase mechanism within libgit2.

epage added a commit to epage/git2-ext that referenced this issue Jan 5, 2023

feat(ops)!: Support signing commits

ffdf38a

This was done based on arxanas/git-branchless#465. Unsure what to do about `cherry_pick` as that uses the rebase mechanism within libgit2.

arxanas mentioned this issue Jan 6, 2023

support for signed commits jj-vcs/jj#58

Closed

arxanas added the help wanted Extra attention is needed label Jun 7, 2023

tommyip linked a pull request Jun 14, 2023 that will close this issue

[WIP] Support GPG-signing commits #966

Draft

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support GPG-signing commits #465

Support GPG-signing commits #465

arxanas commented Jul 18, 2022

lthms commented Jul 23, 2022

epage commented Jan 5, 2023

epage commented Jan 5, 2023

epage commented Jan 5, 2023

hauleth commented May 9, 2023

arxanas commented May 12, 2023

hauleth commented May 15, 2023

tommyip commented Jun 1, 2023

necauqua commented Jun 6, 2023

arxanas commented Jun 7, 2023

tommyip commented Jun 7, 2023

lbjarre commented Nov 13, 2023

tommyip commented Nov 13, 2023 •

edited

Loading

hauleth commented Nov 13, 2023

tommyip commented Nov 13, 2023 •

edited

Loading

necauqua commented Nov 13, 2023 •

edited

Loading

claytonrcarter commented Nov 14, 2023

augustebaum commented Oct 4, 2024

Support GPG-signing commits #465

Support GPG-signing commits #465

Comments

arxanas commented Jul 18, 2022

lthms commented Jul 23, 2022

epage commented Jan 5, 2023

epage commented Jan 5, 2023

epage commented Jan 5, 2023

hauleth commented May 9, 2023

arxanas commented May 12, 2023

hauleth commented May 15, 2023

tommyip commented Jun 1, 2023

necauqua commented Jun 6, 2023

arxanas commented Jun 7, 2023

tommyip commented Jun 7, 2023

lbjarre commented Nov 13, 2023

tommyip commented Nov 13, 2023 • edited Loading

hauleth commented Nov 13, 2023

tommyip commented Nov 13, 2023 • edited Loading

necauqua commented Nov 13, 2023 • edited Loading

claytonrcarter commented Nov 14, 2023

augustebaum commented Oct 4, 2024

tommyip commented Nov 13, 2023 •

edited

Loading

tommyip commented Nov 13, 2023 •

edited

Loading

necauqua commented Nov 13, 2023 •

edited

Loading