Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new feature: Add if-match & if-none-match support for reader #5426

Open
1 task
Xuanwo opened this issue Dec 18, 2024 · 2 comments
Open
1 task

new feature: Add if-match & if-none-match support for reader #5426

Xuanwo opened this issue Dec 18, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@Xuanwo
Copy link
Member

Xuanwo commented Dec 18, 2024

Feature Description

OpenDAL supports read_with(path).if_match(etag) but not reader_with(path).if_match(etag), it will be great if we can support it.

Problem and Solution

reader could read diffent range of file, so the etag may need to pass while perform real reading IO. The API should be carefully designed.

Additional Context

No response

Are you willing to contribute to the development of this feature?

  • Yes, I am willing to contribute to the development of this feature.
@Xuanwo Xuanwo added the enhancement New feature or request label Dec 18, 2024
@Xuanwo Xuanwo changed the title new feature: Add if-match support for reader new feature: Add if-match & if-none-match support for reader Dec 18, 2024
@XmchxUp
Copy link
Contributor

XmchxUp commented Dec 24, 2024

Hi, I am trying to implement it.

@Xuanwo
Copy link
Member Author

Xuanwo commented Dec 24, 2024

Hi, I am trying to implement it.

Thant's great! Since this will affect our public API, would you like to propose an RFC first?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants