Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All the Python versions we support now implement sendfile fallback so its likely our sendfile fallback code is no longer needed. #10096

Open
bdraco opened this issue Dec 3, 2024 · 5 comments
Assignees

Comments

@bdraco
Copy link
Member

bdraco commented Dec 3, 2024

On a side note, all the Python versions we support now implement sendfile fallback so its likely our sendfile fallback code is no longer needed.

Originally posted by @bdraco in #10095 (comment)

@bdraco bdraco self-assigned this Dec 3, 2024
@bdraco
Copy link
Member Author

bdraco commented Dec 4, 2024

It looks like we have an env var to turn off SENDFILE for ancient versions of virtualbox

#628

https://www.virtualbox.org/ticket/12597
https://www.virtualbox.org/ticket/9069

@bdraco
Copy link
Member Author

bdraco commented Dec 4, 2024

History #628 #629

@bdraco
Copy link
Member Author

bdraco commented Dec 4, 2024

That bug has been fixed in virtualbox for 6 years now.

I think we can get rid of it in 4.x but keep in in 3.x

@asvetlov
Copy link
Member

asvetlov commented Dec 5, 2024

Should we care about 6 years old virtualbox?
Code cleanup matters for me in terms of the maintenance cost.

@Dreamsorcerer
Copy link
Member

We also don't want to accidentally break existing systems, so dropping it from v4 sounds like a safe move with minimal maintenance cost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants