-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow partial cache keys #627
Comments
Hello @toadjaune. Thank you for your report. We'll investigate the feature request. |
Hello @toadjaune. The purpose of caching is to cover the majority of use cases. If you need more customization we advise to use actions/cache For now I'm going to close the issue. |
@dmitry-shibanov can this be reopened? Partial cache keys are not some obscure use case but an important optimisation widely used in the CI ecosystem. I would guess that 90+% of jobs that use setup-python would benefit from it. It's built into setup-ruby, coming in setup-node, and indeed is actually implemented for some package managers in this code base, just not all of them (eg poetry). |
@dmitry-shibanov can I ask you to reevaluate your stance and incorporate partial keys how to speed up CI builds and be consistent with the rest of setup-{tool} actions? |
Description:
When restoring cache, the current cache management system only uses the primary cache key.
GitHub Actions cache allows specifying multiple prefixes, and restoring older caches, to speed up setup even when there has been a dependency change. Cf corresponding documentation
I'd recommend setting this as an opt-in behaviour, toggleable with a new input, because :
Here's an example of what the configuration could look like (for poetry) :
Here's a configuration roughly equivalent to what I'm proposing here (the cache key is slightly different, but the idea is the same)
We could also expose cache key management to the users through an input parameter, but that seems much more complex and brittle.
Justification:
This change can represent a significant performance improvement on lockfile change, easily several minutes, depending on the project.
Are you willing to submit a PR?
Not at the time, as I have a working workaround (presented above).
The text was updated successfully, but these errors were encountered: