Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORS integration #81

Open
annevk opened this issue Nov 28, 2024 · 1 comment
Open

CORS integration #81

annevk opened this issue Nov 28, 2024 · 1 comment
Assignees
Labels
Has initial answer Has at least one answer from admins

Comments

@annevk
Copy link

annevk commented Nov 28, 2024

Do these new request headers go across the origin boundary? What's the CORS story?

@kmonsen
Copy link
Collaborator

kmonsen commented Dec 23, 2024

Thank you for the feedback!

The headers will only be sent on to the registration/refresh endpoints. These are set up during the registration, but can be changed during refreshes.

The refresh endpoint has to be samesite, or sharing eTLD+1, with the session, so it will only be sent to the same eTLD+1. There is another restriction, if you you try to set up a session on a parent domain there needs to be a /.well-known/ to say this is OK.

One thing to note is that the user agent will follow redirects on the requests, and they could go everywhere.

Happy to restrict these a bit more if you think that makes sense.

@kmonsen kmonsen self-assigned this Dec 23, 2024
@kmonsen kmonsen added the Has initial answer Has at least one answer from admins label Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Has initial answer Has at least one answer from admins
Projects
None yet
Development

No branches or pull requests

2 participants