Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🐞] v2 - the optimizer does not change props to a single variable #7122

Open
Varixo opened this issue Dec 2, 2024 · 1 comment · Fixed by #7191
Open

[🐞] v2 - the optimizer does not change props to a single variable #7122

Varixo opened this issue Dec 2, 2024 · 1 comment · Fixed by #7191

Comments

@Varixo
Copy link
Member

Varixo commented Dec 2, 2024

Which component is affected?

Qwik optimizer (rust)

Describe the bug

if prop is an aliased string, the optimizer does not change props to a single variable
Doesn't work:

    const Input = component$(
      ({ 'test': abcd}) => {
        return <div></div>;
      }
    );

Works:

    const Input = component$(
      ({ test: abcd}) => {
        return <div></div>;
      }
    );

Reproduction

https://qwik.dev/playground/#f=Q040lhYkJxqI7yDVrS1ymgFaoFGtoF4CLHTVrRQSk5JTauF%2BR6QjUJMC0rCwBorXcgHdREo6hIYexHq4pzStRxPi0EuIAA

Steps to reproduce

No response

System Info

v2

Additional Information

No response

@Varixo Varixo added TYPE: bug Something isn't working STATUS-1: needs triage New issue which needs to be triaged labels Dec 2, 2024
@Varixo Varixo moved this to Upcoming in Qwik Development Dec 2, 2024
@Varixo Varixo added VERSION: upcoming major COMP: optimizer and removed STATUS-1: needs triage New issue which needs to be triaged labels Dec 3, 2024
@Varixo
Copy link
Member Author

Varixo commented Dec 3, 2024

probably same issue #3926

@Varixo Varixo linked a pull request Dec 24, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Upcoming
Development

Successfully merging a pull request may close this issue.

1 participant