You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
but some of the errors to be thrown needs more information, like DomainError(). BTW, custom_error_handler is actually never used directly but always through GSL_ERROR, which hides all arguments but errno. Thus, probably also GLS_ERROR needs some redesign.
PS: as a general comment, this package really needs some serious improvement in test coverage. There are really old cruft in the code, like calls to Compat.@dep_vectorize_2arg, I'm even surprised this macro is still in Compat.
The text was updated successfully, but these errors were encountered:
While trying the reproduce the issue reported in #63 I've noted that
custom_error_handler
needs a redesign. This is its current signature:but some of the errors to be thrown needs more information, like
DomainError()
. BTW,custom_error_handler
is actually never used directly but always throughGSL_ERROR
, which hides all arguments buterrno
. Thus, probably alsoGLS_ERROR
needs some redesign.PS: as a general comment, this package really needs some serious improvement in test coverage. There are really old cruft in the code, like calls to
Compat.@dep_vectorize_2arg
, I'm even surprised this macro is still inCompat
.The text was updated successfully, but these errors were encountered: