Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom_error_handler needs redesign #84

Open
giordano opened this issue Oct 20, 2018 · 0 comments
Open

custom_error_handler needs redesign #84

giordano opened this issue Oct 20, 2018 · 0 comments

Comments

@giordano
Copy link
Member

While trying the reproduce the issue reported in #63 I've noted that custom_error_handler needs a redesign. This is its current signature:

custom_error_handler(reason::AbstractString, file::AbstractString, line::Integer, errno::Integer)

but some of the errors to be thrown needs more information, like DomainError(). BTW, custom_error_handler is actually never used directly but always through GSL_ERROR, which hides all arguments but errno. Thus, probably also GLS_ERROR needs some redesign.

PS: as a general comment, this package really needs some serious improvement in test coverage. There are really old cruft in the code, like calls to Compat.@dep_vectorize_2arg, I'm even surprised this macro is still in Compat.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant