-
-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dedup Large Number of Playlists #26
Comments
Could you share a link to the playlist that gets stuck? Also, if it does delete duplicates, does it mean it eventually doesn’t find duplicates if you run it several times? |
Just for completeness, there are corner cases that are difficult to fix because they are hard to reproduce. |
Additional Testing: Firefox (Windows 10) jumps from 100 playlists left to process to 85 to 18 and hangs there (my usual browser) Chrome (Windows 10) shows each number as it checks the playlists from 100 and hangs at 21 left to process (both desktop and iphone SE mobile app) Safari (iphone SE mobile) performs similarly to Chrome, and hangs at 21 as well Thanks! |
Wow, thank you so much for the detailed report, @shelaffs! I tried finding out where the problem was by checking at Sentry, the error reporting tool I use, but I can't see any recent error there. I could try to reproduce the error if we knew what playlist was causing the error and then I created one with the same content, but for that we need to identify the faulty one. If you could access the network panel in the developer tools of your browser there should be an error that could help debugging this. I think the best way to solve this would be to add additional error reporting and error handling and then try again. My guess is that there is an error fetching tracks from one of the playlists. Looking at the code there is no error handling in the calls to I'll try to find some time to add more error handling that can display on the page that there was a problem with a certain playlist. |
Okay I ran it in Firefox and Chrome. I don't know how to download the report but everything looked fine in Firefox except for a 500 error in the very beginning that didn't seem to affect much. I then ran it in Chrome and it transferred much less data and seemed to return a good number of errors The playlists affected in order of the errors were: These are all large playlists that I add tracks to almost daily, so I'm not at all surprised to see the errors coming from these. Is there a way to isolate the tracks that are returning the error? The error appeared to be identical or very similar for each one that was returned Thank you! |
I tried to find duplicates in https://open.spotify.com/playlist/4cQ71zUu9D5MHa7eglNbSt from my account and it found duplicated tracks without throwing any error. I plan to wrok on error handling to notify when something goes wrong and make the tool "continue" if there is an eventual issue fetching the list of tracks for a playlist. This will take some time though so we shouldn't expect an easy fix. |
I appreciate you looking into it. Just as one last test, I created a new playlist and dragged all tracks from the effected playlist with 4 errors (also the most tracks) and it did not get pulled for duplicates either, so I don't think recreating the playlists would help, but I was hopeful. Thanks again for all your help, it's a fantastic tool =) |
Thanks a lot to you! These conversations are what make me feel that these projects are useful and encourage me to continue working on them. I’ll update the thread when I have any update. In the meantime I’m cleaning up some code and improving testing and error handling for part of the app. |
Thanks for letting me know @shelaffs! I've been improving the code a little bit to do better error handling but there are still a few things to do. |
When processing a large number of playlists (counter starts at 100, I have 92 user playlists, +9 Spotify defaults) the search always seems to get stuck at 18 playlists remaining to process, even when allowing for a significant amount of time to pass (10+min - 1 hour).
The search does process some playlists but does not respond when "remove duplicates" button is pressed on those that are processed, but the duplicates do appear to get removed.
The issue has been present for at least 3 weeks.
The text was updated successfully, but these errors were encountered: