Skip to content
This repository has been archived by the owner on Aug 7, 2023. It is now read-only.

Mistake in the Contributing Guidelines #173

Open
ericcornelissen opened this issue Dec 29, 2017 · 0 comments
Open

Mistake in the Contributing Guidelines #173

ericcornelissen opened this issue Dec 29, 2017 · 0 comments

Comments

@ericcornelissen
Copy link
Contributor

Hi, while I was working on my first PR for this repository I found a small mistake in the Contributing Guidelines but I'm unsure as to what the intended content is... The CONTRIBUTING.md contains the following line

-   Code should pass `npm test` (alias of `eslint .`).

However, when you look at the package.json ⬇️ you can see that npm test is an alias for apm test and not eslint . (which is aliased by npm run lint)

"scripts": {
"test": "apm test",
"lint": "eslint ."
},

Again, I'm unsure what you guys originally intended, but I guess it should be something like:

-   Code should pass `npm test` and `npm run lint` (this tests and lints your changes).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant