Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The backend Script.sh needs to be optimized #93

Open
Karmvirjadeja opened this issue Dec 24, 2024 · 1 comment
Open

The backend Script.sh needs to be optimized #93

Karmvirjadeja opened this issue Dec 24, 2024 · 1 comment

Comments

@Karmvirjadeja
Copy link

  1. Readability
    If you or someone else revisits the script after some time, it can take extra effort to understand its intent.
    If the script fails at some point, without clear explanations, tracking down the issue becomes more challenging.
  2. Error Handling
    The script could silently fail without any indication of the problem, causing later stages to rely on incomplete or missing files.
    This could cause failures in other parts of the project that depend on the setup being complete (e.g., the repository files or Sense2Vec models being unavailable).
  3. Efficiency
    Over time, adding unnecessary steps (like redundant mkdir) can make the script harder to maintain and increase execution time, especially if you have larger scripts or workflows.
  4. Proper Deactivation of Virtual Environment
    f the script fails to deactivate the virtual environment properly, you may end up in a situation where the virtual environment is still active, potentially causing conflicts with other processes or scripts.
    Leaving the virtual environment active unintentionally can cause problems in subsequent operations (like if you run another script that expects the global Python environment)
@Karmvirjadeja
Copy link
Author

Karmvirjadeja commented Dec 24, 2024

I have completed optimization, and have pushed the code. so I request the mentor to review it, and suggest if any changes are required.

Karmvirjadeja added a commit to Karmvirjadeja/EduAid that referenced this issue Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant